Skip to content

ensure that unistd.h is included on recent clang #2949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orbeckst merged 1 commit into from
Sep 23, 2020
Merged

ensure that unistd.h is included on recent clang #2949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion package/CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ Fixes
* libmdaxdr and libdcd classes in their last frame can now be pickled
(Issue #2878, PR #2911)
* AtomGroup now are pickled/unpickled without looking for its anchored
Universe (PR #2893)
Universe (PR #2893)
* ensure that unistd.h is included on macOS when compiling ENCORE's spe.c
(Issue #2934)

Enhancements
* Refactored analysis.helanal into analysis.helix_analysis
Expand Down
6 changes: 2 additions & 4 deletions package/MDAnalysis/analysis/encore/dimensionality_reduction/src/spe.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,10 @@
#include <time.h>
#include <sys/types.h>

#ifdef __unix__
#include <unistd.h>
#endif

#ifdef _WIN32
#include <io.h>
#else /* unix-like __unix__ || __APPLE__ */
#include <unistd.h>
#endif

#define EPSILON 1e-8
Expand Down