Skip to content

Change CHARMM selection syntax page#2972

Merged
lilyminium merged 1 commit intoMDAnalysis:developfrom
IAlibay:issue-2971
Oct 6, 2020
Merged

Change CHARMM selection syntax page#2972
lilyminium merged 1 commit intoMDAnalysis:developfrom
IAlibay:issue-2971

Conversation

@IAlibay
Copy link
Copy Markdown
Member

@IAlibay IAlibay commented Oct 6, 2020

Fixes #2971

Changes made in this Pull Request:

  • swaps the old CHARMM selection syntax page to new one.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Copy link
Copy Markdown
Member

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this would go into master as well, do we have a backports PR going on?

@IAlibay
Copy link
Copy Markdown
Member Author

IAlibay commented Oct 6, 2020

Ideally this would go into master as well, do we have a backports PR going on?

I was just looking for it, but I think the last one got merged, I'll raise a separate PR.

@IAlibay IAlibay mentioned this pull request Oct 6, 2020
2 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 6, 2020

Codecov Report

Merging #2972 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2972      +/-   ##
===========================================
- Coverage    93.05%   93.03%   -0.02%     
===========================================
  Files          186      186              
  Lines        24609    24542      -67     
  Branches      3187     3187              
===========================================
- Hits         22900    22833      -67     
  Misses        1661     1661              
  Partials        48       48              
Impacted Files Coverage Δ
auxiliary/base.py 90.75% <0.00%> (-0.57%) ⬇️
coordinates/base.py 94.85% <0.00%> (-0.27%) ⬇️
util.py 89.39% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecaec3f...282886b. Read the comment docs.

@lilyminium lilyminium merged commit 5e8caf0 into MDAnalysis:develop Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CHARMM selection syntax link no longer works

3 participants