change CHARMM selection syntax page#2973
Merged
lilyminium merged 1 commit intoMDAnalysis:masterfrom Oct 6, 2020
Merged
Conversation
lilyminium
approved these changes
Oct 6, 2020
Member
lilyminium
left a comment
lilyminium
left a comment
There was a problem hiding this comment.
LGTM, master version of #2972 :-)
Codecov Report
@@ Coverage Diff @@
## master #2973 +/- ##
==========================================
+ Coverage 91.57% 92.17% +0.59%
==========================================
Files 168 169 +1
Lines 23368 23177 -191
Branches 3186 3186
==========================================
- Hits 21400 21364 -36
- Misses 1342 1716 +374
+ Partials 626 97 -529
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2971
Changes made in this Pull Request:
PR Checklist