Skip to content

backport of stub transplants of AtomGroup (PR #2427)#3007

Merged
orbeckst merged 2 commits intomasterfrom
backport-PR2427
Oct 23, 2020
Merged

backport of stub transplants of AtomGroup (PR #2427)#3007
orbeckst merged 2 commits intomasterfrom
backport-PR2427

Conversation

@orbeckst
Copy link
Member

@orbeckst orbeckst commented Oct 23, 2020

Fixes #1845 (for 1.x)

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs? – checked locally: methods are now included in AtomGroup
  • CHANGELOG updated?
  • Issue raised/referenced?

- Fixes #1845
- Adds dummy method with documentation of original method
- Dummy method gets replaced by actual method on instantiation

(cherry picked from commit 799100b)
@orbeckst orbeckst added this to the 1.0.x milestone Oct 23, 2020
@orbeckst orbeckst changed the title update CI files for Py2/Py3 packages backport of stub transplants of AtomGroup (PR #2427) Oct 23, 2020
@orbeckst
Copy link
Member Author

oops. missed a commit... stand by

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #3007 into master will increase coverage by 0.71%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3007      +/-   ##
==========================================
+ Coverage   91.51%   92.23%   +0.71%     
==========================================
  Files         168      171       +3     
  Lines       22954    23618     +664     
  Branches     3186     3192       +6     
==========================================
+ Hits        21006    21783     +777     
- Misses       1322     1738     +416     
+ Partials      626       97     -529     
Impacted Files Coverage Δ
package/MDAnalysis/core/groups.py 99.01% <100.00%> (+0.77%) ⬆️
package/MDAnalysis/core/topologyattrs.py 96.80% <100.00%> (+1.17%) ⬆️
package/MDAnalysis/topology/tpr/obj.py 96.82% <0.00%> (-3.18%) ⬇️
...onality_reduction/DimensionalityReductionMethod.py 97.14% <0.00%> (-2.86%) ⬇️
package/MDAnalysis/transformations/translate.py 97.43% <0.00%> (-2.57%) ⬇️
package/MDAnalysis/analysis/base.py 100.00% <0.00%> (ø)
package/MDAnalysis/lib/c_distances.pyx
package/MDAnalysis/analysis/encore/cutils.pyx
...alysis/analysis/encore/clustering/affinityprop.pyx
package/MDAnalysis/due.py 56.09% <0.00%> (ø)
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4fa754...e12bd3f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants