Skip to content

removed funcsigs (not needed for Py >= 3.6)#3008

Merged
orbeckst merged 1 commit intodevelopfrom
remove-funcsigs
Oct 24, 2020
Merged

removed funcsigs (not needed for Py >= 3.6)#3008
orbeckst merged 1 commit intodevelopfrom
remove-funcsigs

Conversation

@orbeckst
Copy link
Member

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@orbeckst orbeckst added this to the 2.0 milestone Oct 23, 2020
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #3008 into develop will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3008      +/-   ##
===========================================
+ Coverage    93.05%   93.12%   +0.07%     
===========================================
  Files          186      171      -15     
  Lines        24663    22652    -2011     
  Branches      3197     3197              
===========================================
- Hits         22950    21095    -1855     
+ Misses        1665     1509     -156     
  Partials        48       48              
Impacted Files Coverage Δ
package/MDAnalysis/core/topologyattrs.py 96.61% <100.00%> (+0.17%) ⬆️
lib/__init__.py
topology/base.py
__init__.py
topology/__init__.py
coordinates/base.py
util.py
transformations/__init__.py
formats/__init__.py
core/__init__.py
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799100b...3431f8a. Read the comment docs.

Copy link
Member

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 straightforward, thanks!

@orbeckst orbeckst self-assigned this Oct 24, 2020
@orbeckst orbeckst merged commit 5ac87b6 into develop Oct 24, 2020
@orbeckst orbeckst deleted the remove-funcsigs branch October 24, 2020 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants