Skip to content

increase default Python to 3.7 on Travis CI#3011

Merged
orbeckst merged 2 commits intomasterfrom
update-travis-python-default
Oct 24, 2020
Merged

increase default Python to 3.7 on Travis CI#3011
orbeckst merged 2 commits intomasterfrom
update-travis-python-default

Conversation

@orbeckst
Copy link
Member

Fixes : currently broken master (from 73cd1e6)

Changes made in this Pull Request:
- set PYTHON_VERSION=3.7
- set MAMBA=false for Python 3.5 (no mamba package available, fall back
to conda)

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

- set PYTHON_VERSION=3.7
- set MAMBA=false for Python 3.5 (no mamba package available, fall back
  to conda)
@orbeckst
Copy link
Member Author

I broke the CI by directly cherry-picking 73cd1e6 (PR #2983 ) onto master without realizing that there's no mamba for Python 3.5 (which we still run for 1.x). This PR sets the default to 3.7 and ensures that mamba is not used for the sole 3.5 test.

@orbeckst orbeckst added this to the 1.0.x milestone Oct 24, 2020
This was referenced Oct 24, 2020
@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #3011 into master will increase coverage by 0.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3011      +/-   ##
==========================================
+ Coverage   91.41%   92.03%   +0.62%     
==========================================
  Files         165      172       +7     
  Lines       22855    24053    +1198     
  Branches     3192     3193       +1     
==========================================
+ Hits        20893    22138    +1245     
- Misses       1332     1818     +486     
+ Partials      630       97     -533     
Impacted Files Coverage Δ
package/MDAnalysis/topology/tpr/obj.py 96.82% <0.00%> (-3.18%) ⬇️
...onality_reduction/DimensionalityReductionMethod.py 97.14% <0.00%> (-2.86%) ⬇️
package/MDAnalysis/analysis/base.py 100.00% <0.00%> (ø)
package/MDAnalysis/lib/_augment.pyx
package/MDAnalysis/analysis/legacy/x3dna.py 0.00% <0.00%> (ø)
package/MDAnalysis/lib/nsgrid.pyx 83.72% <0.00%> (ø)
package/MDAnalysis/tests/__init__.py 100.00% <0.00%> (ø)
package/MDAnalysis/tests/datafiles.py 31.25% <0.00%> (ø)
package/MDAnalysis/analysis/legacy/__init__.py 0.00% <0.00%> (ø)
package/MDAnalysis/lib/formats/libdcd.pyx 88.64% <0.00%> (ø)
... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73cd1e6...20039ca. Read the comment docs.

@orbeckst
Copy link
Member Author

numpy 1.13.4 only available as conda package for 2.7 and 3.6... https://anaconda.org/conda-forge/numpy/files?page=12

NumPy 13.3.3 packages are available for Python 2.7 and 3.6 only so for the tests with the
minimal numpy version we set Python to 3.6.
@orbeckst orbeckst merged commit 2ef90f2 into master Oct 24, 2020
@orbeckst orbeckst deleted the update-travis-python-default branch October 24, 2020 16:29
@orbeckst orbeckst self-assigned this Oct 24, 2020
lilyminium pushed a commit to lilyminium/mdanalysis that referenced this pull request Dec 9, 2020
* increase default Python to 3.7 on Travis CI
   - set PYTHON_VERSION=3.7
   - set MAMBA=false for Python 3.5 (no mamba package available, fall backto conda)
* ensure conda package is available for numpy 1.13
   NumPy 13.3.3 packages are available for Python 2.7 and 3.6 only so for the tests with the
   minimal numpy version we set Python to 3.6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants