Move results attributes of helix_analysis to Results

[lilyminium]

Fixes #3268
Fixes #3267

Changes made in this Pull Request:

• changed versionchanged to the right number
• Moved attributes to results

I did not add a deprecation warning because this analysis is new in 2.0.0.

PR Checklist

• Tests?
• Docs?
• CHANGELOG updated?
• Issue raised/referenced?

[pep8speaks]

Hello @lilyminium! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file package/MDAnalysis/analysis/helix_analysis.py:

Line 426:80: E501 line too long (83 > 79 characters)

Comment last updated at 2021-05-07 22:02:29 UTC

[codecov]

Codecov Report

Merging #3279 (d63d389) into develop (be3ec1b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #3279   +/-   ##
========================================
  Coverage    93.04%   93.04%           
========================================
  Files          172      172           
  Lines        22751    22751           
  Branches      3192     3192           
========================================
  Hits         21168    21168           
  Misses        1533     1533           
  Partials        50       50           

Impacted Files	Coverage Δ
package/MDAnalysis/analysis/helix_analysis.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be3ec1b...d63d389. Read the comment docs.

[orbeckst]

lgtm, just suggestions how to make use of the fact that Results is a dict and get rid of ugly {get,set}attr.

[orbeckst]

Something is not right in how the results are stored now. I am not sure what, I just looked at the failures and they are typically an extra (or missing) level of [ .. ] in the results. Maybe I made a mistake in my quick attr <-> dict translation.

[orbeckst]

I assume you need PR #3281 merged before restarting this one?

[orbeckst]

I'll block the PR until the tests pass (which requires solving #3282 )

[orbeckst]

I am sorry, the CHANGELOG message for this PR was lost after merging PR #3288 – see comment 51fa4e4#r50540088 . This should get fixed when PR #3284 is merged.