Switch DistanceMatrix to Results class#3288
Merged
orbeckst merged 5 commits intoMDAnalysis:developfrom May 8, 2021
Merged
Conversation
|
Hello @PicoCentauri! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-05-07 23:03:18 UTC |
Codecov Report
@@ Coverage Diff @@
## develop #3288 +/- ##
===========================================
+ Coverage 93.01% 93.04% +0.03%
===========================================
Files 172 172
Lines 22751 22754 +3
Branches 3192 3192
===========================================
+ Hits 21161 21171 +10
+ Misses 1540 1533 -7
Partials 50 50
Continue to review full report at Codecov.
|
PicoCentauri
force-pushed
the
diffusionmap-results
branch
from
ba6c2c0 to
a77ac1a
Compare
4 tasks
orbeckst
approved these changes
May 7, 2021
Member
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
Please check if the reST link target needs to be reinserted.
Otherwise all good — minor comment on the tests.
Member
|
Let's just wait for the CI. |
PicoCentauri
force-pushed
the
diffusionmap-results
branch
from
c3f5421 to
d992dfd
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3290
PR Checklist