Skip to content

Start 2.3.0-dev0 🎉#3697

Merged
IAlibay merged 1 commit intodevelopfrom
start-2.3.0
Jun 2, 2022
Merged

Start 2.3.0-dev0 🎉#3697
IAlibay merged 1 commit intodevelopfrom
start-2.3.0

Conversation

@IAlibay
Copy link
Copy Markdown
Member

@IAlibay IAlibay commented Jun 2, 2022

Changes made in this Pull Request:

  • Started new changelog entry set
  • Updated versions

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 2, 2022

Codecov Report

Merging #3697 (7e91dab) into develop (eab18cb) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #3697   +/-   ##
========================================
  Coverage    94.35%   94.35%           
========================================
  Files          191      191           
  Lines        24975    24975           
  Branches      3365     3365           
========================================
  Hits         23565    23565           
  Misses        1362     1362           
  Partials        48       48           
Impacted Files Coverage Δ
package/MDAnalysis/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab18cb...7e91dab. Read the comment docs.

@IAlibay
Copy link
Copy Markdown
Member Author

IAlibay commented Jun 2, 2022

@MDAnalysis/coredevs simple enough one to review if someone can give this a thumbs up that'd be great. You can see how it was done for 2.1.0 here if you want to compare: #3400

Copy link
Copy Markdown
Member

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

You could fix the CHANGELOG #3696 here, too.

@orbeckst orbeckst added this to the 2.3.0 milestone Jun 2, 2022
@IAlibay
Copy link
Copy Markdown
Member Author

IAlibay commented Jun 2, 2022

LGTM.

You could fix the CHANGELOG #3696 here, too.

To avoid re-running CI I'll deal with that with the deploy PR.

@IAlibay IAlibay merged commit d0be0e6 into develop Jun 2, 2022
@IAlibay IAlibay deleted the start-2.3.0 branch June 2, 2022 22:12
@IAlibay IAlibay mentioned this pull request Aug 30, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants