Conversation
Important! Please do not squash-merge! This includes the
|
|
Not really thought about what we'll do if we want to do a bugfix for 2.0.0, I guess we can just do a feature branch from |
Codecov Report
@@ Coverage Diff @@
## develop #3400 +/- ##
===========================================
- Coverage 93.79% 93.79% -0.01%
===========================================
Files 177 177
Lines 23233 23228 -5
Branches 3309 3308 -1
===========================================
- Hits 21792 21787 -5
Misses 1390 1390
Partials 51 51
Continue to review full report at Codecov.
|
|
@MDAnalysis/coredevs we need to get this moving along so that we can get dev back up. |
|
The conversation to be had here is if we want to wait to apply NEP29 until after we know we don't want a bugfix for 2.0.0? If so I can revert some of the changes here and keep 3.6 support until we drop it later? |
orbeckst
left a comment
There was a problem hiding this comment.
Let’s do this in forward looking mode. (The alternative would have been to set the version to 2.0.1 and change it as soon as a new feature goes in.)
Let’s try to make PRs focused so that we could easily backport them to a patch branch on master. Or if we only have fixed on this branch when merging into master we can just change the version information there and then change develop.
Sounds good to me. If anything I'd like to get 2.1.0 out faster (especially so we could get #3044 out there). |
Fixes #3254
Changes made in this Pull Request:
PR Checklist