Skip to content

Conversation

@jazairi
Copy link
Contributor

@jazairi jazairi commented Jul 22, 2025

Why these changes are being introduced:

While debugging a build failure, I noticed a todo to remove a bit of code that we used to test the new AWS org. That migration has finished, so we no longer need it.

Relevant ticket(s):

N/A

How this addresses that need:

This removes the line of code in question.

Side effects of this change:

None.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

YES | NO

Includes new or updated dependencies?

YES | NO

Why these changes are being introduced:

While debugging a build failure, I noticed a todo to remove a
bit of code that we used to test the new AWS org. That migration
has finished, so we no longer need it.

Relevant ticket(s):

N/A

How this addresses that need:

This removes the line of code in question.

Side effects of this change:

None.
Copy link
Member

@JPrevost JPrevost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@jazairi jazairi force-pushed the fake-auth-update branch from 37515b0 to 31a86de Compare July 22, 2025 18:16
@jazairi jazairi temporarily deployed to thesis-submit-pr-1466 July 22, 2025 18:16 Inactive
@jazairi jazairi merged commit 3e33fd2 into main Jul 22, 2025
1 check passed
@jazairi jazairi deleted the fake-auth-update branch July 22, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants