Skip to content

Remove testing line from fake auth config #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jazairi merged 1 commit into from
Jul 22, 2025
Merged

Remove testing line from fake auth config #1466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions app/models/concerns/fake_auth_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,6 @@ def self.fake_auth_status
private_class_method def self.app_name_pattern_match?
return true if Rails.env.development?

# TODO: remove this line once we have confirmed the S3 and SQS migration to the new AWS org. We created a temporary
# second review app to test that migration.
return true if ENV.fetch('HEROKU_APP_NAME', nil) == 'thesis-submit-staging-new'

review_app_pattern = /^thesis-(submit|dropbox)-pr-\d+$/
review_app_pattern.match(ENV.fetch('HEROKU_APP_NAME', nil)).present?
end
Expand Down
7 changes: 0 additions & 7 deletions test/models/fake_auth_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,4 @@ class FakeAuthTest < ActiveSupport::TestCase
assert_equal(false, FakeAuthConfig.fake_auth_status)
end
end

test 'fakeauth enabled temp staging app name' do
ClimateControl.modify FAKE_AUTH_ENABLED: 'true',
HEROKU_APP_NAME: 'thesis-submit-staging-new' do
assert_equal true, FakeAuthConfig.fake_auth_status
end
end
end