Skip to content

refactor(has_pkg): introduce strict flag#106

Merged
wpbonelli merged 1 commit into
MODFLOW-ORG:developfrom
wpbonelli:has-pkg
Aug 12, 2023
Merged

refactor(has_pkg): introduce strict flag#106
wpbonelli merged 1 commit into
MODFLOW-ORG:developfrom
wpbonelli:has-pkg

Conversation

@wpbonelli
Copy link
Copy Markdown
Member

@wpbonelli wpbonelli commented Aug 12, 2023

  • add strict param to has_pkg() toggling whether to try to import the pkg or only check metadata
    • always invalidate/refresh the cache if strict is on
  • add pytest-virtualenv to test dependencies, test with/without strict
    • use --dist loadfile with xdist in CI for compatibility
  • motivated by ci: smoke test with/out optional dependencies, mark more tests modflowpy/flopy#1918, tests marked with requires_pkg could fail if a pkg has been installed but is missing dependencies

@wpbonelli wpbonelli force-pushed the has-pkg branch 3 times, most recently from 9adf9f3 to c917bce Compare August 12, 2023 16:35
* add strict param to has_pkg() toggling whether to try to import the pkg or only check metadata
* always invalidate/refresh the cache if strict is on
* add pytest-virtualenv to test dependencies, test with/without strict
* use --dist loadfile with xdist in CI for compatibility
* use strict=True for requires_pkg marker
@wpbonelli wpbonelli merged commit 03ea041 into MODFLOW-ORG:develop Aug 12, 2023
@wpbonelli wpbonelli deleted the has-pkg branch August 12, 2023 16:47
This was referenced Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant