ci: smoke test with/out optional dependencies, mark more tests#1918
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1918 +/- ##
=========================================
Coverage 72.6% 72.6%
=========================================
Files 257 257
Lines 56210 57585 +1375
=========================================
+ Hits 40835 41835 +1000
- Misses 15375 15750 +375 |
6dde59f to
732e817
Compare
mwtoews
left a comment
There was a problem hiding this comment.
Looks good so far. It adds about 5 mins to the smoke tests. It seems the smoke test does not upload it's coverage, it probably should to see the changes.
* use current date as random seed * upload artifact reporting which deps were removed
97fe46f to
4dcf4a1
Compare
|
@mwtoews I wonder if it may be worth randomizing the choice of dependencies to test without. I added a mechanism to do so and moved optional dependency testing to nightly schedule. Let me know if this seems unreasonable. |
67c424a to
719af7f
Compare
|
I like the idea to randomize optional deps, as there are potential combinations that may cause issues. We can see how it goes. If it becomes too much of a maintenance burden, then the randomization can be disabled. And I'd agree it doesn't make sense to upload an unstable coverage report. |
mwtoews
left a comment
There was a problem hiding this comment.
It's probably better to keep the smoke tests short, so moving optional tests to their own workflow seems the right way. However, I don't see any tests from optional.yml.
|
I put optional.yml on a nightly schedule and set to choose a different random 3 dependencies every day, hopefully that should not be too burdensome to stay on top of and we also avoid bloating regular CI. |
|
That's why it's not triggered with pull requests. A schedule should work well. |
Uh oh!
There was an error while loading. Please reload this page.