Skip to content

Update COMPASS scripts to support python 3#177

Merged
mark-petersen merged 5 commits intoMPAS-Dev:developfrom
xylar:compass/python_3
Apr 9, 2019
Merged

Update COMPASS scripts to support python 3#177
mark-petersen merged 5 commits intoMPAS-Dev:developfrom
xylar:compass/python_3

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Mar 7, 2019

The changes mostly involve fixing print statements.

The list command has also been modified to produce a sorted list of test cases (as opposed to the random order that was previously produced).

This isn't related to python 3, just something that drives me nuts
about the script...
Also, remove an unneeded import
@xylar xylar requested a review from mark-petersen March 7, 2019 02:42
@xylar xylar self-assigned this Mar 7, 2019
@xylar xylar added the COMPASS label Mar 7, 2019
@xylar
Copy link
Collaborator Author

xylar commented Mar 7, 2019

@mark-petersen, could you make sure these changes work for you when using COMPASS as normal?

If so, we'll want to merge develop into ocean/develop once this is merged to develop.

@xylar xylar requested a review from matthewhoffman March 7, 2019 02:43
@xylar
Copy link
Collaborator Author

xylar commented Mar 7, 2019

@matthewhoffman, could you make sure land-ice test cases still work as expected with these updated versions of the scripts?

@xylar
Copy link
Collaborator Author

xylar commented Mar 13, 2019

The intention is just to test that these don't break python 2.7 support for now. Many other COMPASS scripts aren't ready for python 3 yet, so that testing will need to wait.

@mark-petersen mark-petersen self-requested a review April 9, 2019 19:21
Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all scripts:
clean_testcase.py list_testcases.py manage_regression_suite.py setup_testcase.py
for --help, case listing, case creation, ran a single setup case, ran a nightly regression, and cleaned a case. I committed a few small updates, and everything works.

@mark-petersen
Copy link
Contributor

Asked @matthewhoffman and he was satisfied with my ocean tests. Removing him as a reviewer.

@mark-petersen mark-petersen removed the request for review from matthewhoffman April 9, 2019 19:25
@mark-petersen mark-petersen assigned xylar and unassigned xylar Apr 9, 2019
@xylar
Copy link
Collaborator Author

xylar commented Apr 9, 2019

@mark-petersen, sorry about that. Thanks for the fixes. Any reason I shouldn't go ahead and merge this to develop?

@mark-petersen
Copy link
Contributor

@xylar, just coordinating timing. @mgduda is merging several small PRs right now, I'll do this one later today so we don't force him to redo his local merge.

@xylar
Copy link
Collaborator Author

xylar commented Apr 9, 2019

Okay, glad I asked. I'll leave it to you.

@xylar xylar assigned mark-petersen and unassigned xylar Apr 9, 2019
@mark-petersen mark-petersen merged commit d1cce62 into MPAS-Dev:develop Apr 9, 2019
mark-petersen added a commit that referenced this pull request Apr 9, 2019
The changes mostly involve fixing print statements.

The list command has also been modified to produce a sorted list of test
cases (as opposed to the random order that was previously produced).
@xylar xylar deleted the compass/python_3 branch April 9, 2019 22:30
@xylar xylar mentioned this pull request Apr 17, 2019
mark-petersen added a commit that referenced this pull request May 9, 2019
The utility_scripts were not included in #177

Fixes a bug by decoding the git_version into a unicode string in
manage_regression_test_suite.py, required for python 3 compatibility.
dustinswales pushed a commit to dustinswales/MPAS-Model that referenced this pull request Dec 5, 2025
…r to update global attributes (MPAS-Dev#177)

* add a new stream property 'gattr_update' to control whether to update global attributes

* fix a typo: interger -> integer

* bump version to 8.3.1-2.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants