Fix decoding issue of git version for py3#222
Fix decoding issue of git version for py3#222mark-petersen merged 3 commits intoMPAS-Dev:developfrom
Conversation
TestingI used this fix as part of testing my new COMPASS conda environment for python 3 (see MPAS-Dev/geometric_features#102 (comment)). |
xylar
force-pushed
the
compass/fix_git_version_for_py3
branch
from
8f2a5da to
834b3b8
Compare
There was a problem hiding this comment.
Lots of tabs have been replaced with spaces. It's a bad practice to have a mix of tabs and spaces in a python file, and generally tabs should be avoided.
There was a problem hiding this comment.
Thanks. I appreciate that.
|
@mark-petersen, this was included in #229 and was therefore part of your testing and mine. However, it needs to get merged to |
Apparently missed in testing of py3 conversion.
xylar
force-pushed
the
compass/fix_git_version_for_py3
branch
from
b01cd24 to
5681879
Compare
mark-petersen
left a comment
mark-petersen
left a comment
There was a problem hiding this comment.
Tested with #229. It all works, see notes there.
|
@mgduda and @matthewhoffman: FYI this is COMPASS only, but a merge into develop. It does not affect atmosphere core. I will be merging this today. |
The utility_scripts were not included in #177 Fixes a bug by decoding the git_version into a unicode string in manage_regression_test_suite.py, required for python 3 compatibility.
|
Thanks! |
3 participants
The
utility_scriptswere not included in #177Fixes a bug by decoding the
git_versioninto a unicode string inmanage_regression_test_suite.py, required for python 3 compatibility.