Fix git describe for repo without any tags#18
Merged
xylar merged 1 commit intoMPAS-Dev:masterfrom Nov 9, 2020
Merged
Conversation
Collaborator
Author
|
@mark-petersen and @matthewhoffman, this should go in right after #2 and #3 so the repo is actually usable. |
matthewhoffman
approved these changes
Nov 9, 2020
Member
matthewhoffman
left a comment
matthewhoffman
left a comment
There was a problem hiding this comment.
I'm not familiar with the --always argument, but it sounds like it provides a fallback to return something useful without causing undesired behavior in situations where git describe works. Unless I'm missing something, that sounds desirable, and this change makes sense to me.
mark-petersen
approved these changes
Nov 9, 2020
Collaborator
mark-petersen
left a comment
mark-petersen
left a comment
There was a problem hiding this comment.
Looks good. I'm definitely surpassing "you learn something new every day"
Collaborator
Author
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this repo doesn't have any tags yet,
git describewill fail unless it has an--alwaysflag. This fix is needed before this repo will be useful for testing.