Merge COMPASS contents from MPAS-Dev/MPAS-Model/ocean/develop#2
Merge COMPASS contents from MPAS-Dev/MPAS-Model/ocean/develop#2xylar merged 538 commits intoMPAS-Dev:masterfrom
Conversation
Cells below maxLevelCell are no longer included.
This merge moves soma/4km/32to4km and soma/8km/32to8km test cases into a new subdirectory called "broken" since these test cases are not working and won't be fixed anytime soon. With this change, `./list_testcases.py` and `./setup_testcases.py` won't pick up these tests because their driver config files aren't at the expected directory level.
The Maine, QU60 and SOQU60to15 test cases now have the links to the python script for defining their vertical grids that they need to be set up successfully.
We no longer define a path to metis in the config file, so the version from the conda environment needs to be used instead.
Add support for a "conda_mpi" attribute to "step" tags. If this attribute is set to "true" and MPI is present in the conda environment, that command will be called with `mpirun` from the conda envrionment. This is needed to support compass conda enviornments with mpich. Python scripts and modules that use the netcdf4 package with mpich support don't work properly on many compute nodes (e.g. Grizzly at LANL and Anvil at ANL) unless they are prefixed with `mpirun -np 1`
The paraview extractor can now be called as a function rather than a script, and this is done during base-mesh generation and culling. SCRIP files can now also be created with a function, so a script call is replaced with a function here as well. With these changes, calls to python scripts that use NetCDF in the parallel conda enviornment will now work as long as they are called with `mpirun -np 1`
Also rename the load script for convenience.
This will make sure the compatible version of MPI gets used.
Since we can't detect automatically that this is a python script, (and that it needs to support compass mpi) we need to say so explicitly
This change is needed because of a recent modification (MPAS-Dev#495) to `build_mesh.py`
set: config_AM_mixedLayerDepths_Tgradient = .false. config_AM_mixedLayerDepths_Dgradient = .false. write MLD AM every time step for restart test
This is specified either in the config file or at the command line.
…n/develop Switch ARM creation to signed distance function MPAS-Dev#515 As a warm-up to revising the EC60to30 and CUSP mesh, I switched ARM from the hard-wired function `AtlanticPacificGrid` to signed distance based on a geojson file. The new steps are: - Create cell width vs latitude for Atlantic and Pacific basins - Expand from 1D to 2D - Signed distance of Atlantic region - Merge Atlantic and Pacific distrubutions smoothly - Merge Atlantic and Pacific distrubutions with step function - Create a land mask that is 1 over land - Merge: step transition over land, smooth transition over water
… ocean/develop Optionally add links to load_compass_env.sh in test cases MPAS-Dev#492 This is specified either in the config file or at the command line. Like MPAS-Dev#480, this involves changes to common COMPASS infrastructure and we should consider making a separate PR to develop instead of merging those changes to ocean/develop. closes MPAS-Dev#490
Each test case with an E3SM coupling step now needs a default and and custom config file for that test case. The custom config file will be used to point to the correct initial condition, give the full mesh name and other metadata, etc. For now, only the 2 EC60to30 test cases have these custom config files, but ther remaining test cases with E3SM coupling steps will have these added later on.
This metadata is formatted according to the specs of @proteanplanet
Switch from institution to email address, which can be parsed from git config (along with the name). Switch metadata from having spaces to underscores. Switch mesh short names from dot separation to underscores.
For example, `ECwISC60to30kmL64E3SMv2r01`
Fix validation for QU240 test step MPAS-Dev#660 Folder is "test", not "forward".
…elop Update to version 0.1.11 of the compass environment MPAS-Dev#688 This brings in several changes from MPAS-Tools: * Changes to make sure the Earth radius is consistent throughout COMPASS and `mpas_tools.ocean` by using the CIME value (MPAS-Dev/MPAS-Tools#347 and MPAS-Dev/MPAS-Tools#341) * Improved performance for interpolation of meshDensity and bathymetry (MPAS-Dev/MPAS-Tools#344) * Reorganization of `mpas_tools.mesh.creation` (MPAS-Dev/MPAS-Tools#314)
This version has a larger region of enhanced resolution around Greenland than EC15to60E2r01.
|
@mark-petersen, I'm just hoping of something of a sanity check from you. For example, that the first commits and last commits make sense and aren't missing anything. And that we're not changing files we don't want to be. Wouldn't hurt to run a test, but maybe not critical either. |
|
@xylar this is great!!! I ran from the head of this branch. I only needed to add a tag: and then everything worked. I tested on grizzly with and ran the nightly regression suite with the head of MPAS-O Only two requests.
if you could remove the |
|
@mark-petersen, thanks very much for testing. I hadn't tried the I'll add the missing commits from |
|
@mark-petersen, I show both commits from MPAS-Dev/MPAS-Model#740 as being the last two commits in this PR. Could you tell me what you think is missing? Merge commits that don't include code changes don't get saved in the process of a |
|
This is what I see: I just didn't understand why the last four commits are on the trunk, rather than showing a merge into the trunk. It's not super important, just nice if it's a matter of rerunning |
|
@mark-petersen, I see. There does seem to be a fairly complicated procedure here: https://stackoverflow.com/a/23901136/7728169 that would preserved the merge commits. I'm not sure I want to do that, particularly because I did not do that for |
mark-petersen
left a comment
There was a problem hiding this comment.
Please merge. Request above is not important enough for the trouble. Thanks!
|
Thanks, @mark-petersen! |
This merge brings in the full history of https://github.com/MPAS-Dev/MPAS-Model/tree/ocean/develop/testing_and_setup/compass