Fix pageNav in tweaking the page structure#1127
Merged
marvinchin merged 11 commits intoMarkBind:masterfrom Mar 24, 2020
Merged
Conversation
* 'master' of https://github.com/MarkBind/markbind: Update tests Allow using 'none' footer attribute in frontmatter (MarkBind#1002) Support line numbers for code blocks (MarkBind#991) 2.11.0 Update test files due to changes in PR MarkBind#982 Update vue-strap version to v2.0.1-markbind.36 Make highlighting bold (MarkBind#1045) Support markdown for header attr in dropdown (MarkBind#1029) Add '_site' to the ignored folders in site.json (MarkBind#1046) Use path.join instead of string interpolation (MarkBind#1052) Implement box markdown header attributes parsing (MarkBind#1025) Make the position of top navbar fixed (MarkBind#982) Exclude *.md files from being copied over on build (MarkBind#1010) # Conflicts: # docs/css/main.css
* 'master' of https://github.com/MarkBind/markbind: 2.12.0 Update outdated test files Update vue-strap version to v2.0.1-markbind.37 Fix refactor to processDynamicResources (MarkBind#1092) Implement lazy page building for markbind serve (MarkBind#1038) Add warnings for conflicting/deprecated component attribs (MarkBind#1057) Allow changing parameter properties (MarkBind#1075) Custom timezone for built-in timestamp (MarkBind#1073) Fix reload inconsistency when updating frontmatter (MarkBind#1068) Implement an api to ignore content in certain tags (MarkBind#1047) Enable AppVeyor CI (MarkBind#1040) Add heading and line highlighting to code blocks (MarkBind#1034) Add dividers and fix bug in siteNav (MarkBind#1063) Fixed navbar no longer covers modals (MarkBind#1070) Add copy code-block plugin (MarkBind#1043) Render plugins on dynamic resources (MarkBind#1051) Documentation for Implement no-* attributes for <box> (MarkBind#1042) Migrate to bootstrap-vue popovers (MarkBind#1033) Refactor preprocess and url processing functions (MarkBind#1026) Add pageNav to Using Plugins Page (MarkBind#1062)
* 'master' of https://github.com/MarkBind/markbind: Add example for using multiple features in code-blocks (MarkBind#1102)
Contributor
Author
|
@damithc Can I get your review on this? |
damithc
reviewed
Mar 16, 2020
| @@ -1,7 +1,9 @@ | |||
| #### `filterTags`: Toggling alternative contents in a page | |||
| ## Filter tags | |||
Contributor
There was a problem hiding this comment.
Filter tags is a new term that is not mentioned anywhere else and not a standard term either.
Perhaps Tags?
damithc
approved these changes
Mar 18, 2020
Contributor
Author
|
@marvinchin Can I get your review on this? |
marvinchin
reviewed
Mar 21, 2020
Contributor
marvinchin
left a comment
marvinchin
left a comment
There was a problem hiding this comment.
Good catch! I think we should change the filename as well since filterTags isn't officially a markbind thing anymore.
| @@ -1,7 +1,9 @@ | |||
| #### `filterTags`: Toggling alternative contents in a page | |||
| ## Tags | |||
Contributor
There was a problem hiding this comment.
Should we rename the file as well?
…x-pageNav * 'master' of https://github.com/MarkBind/markbind: Update test files (MarkBind#1138) Remove OK button from modals (MarkBind#1134) Add start from line number functionality to code blocks (MarkBind#1115) Allow special tags to be self-closing (MarkBind#1101) Simplify baseUrl resolving process (MarkBind#1087) Remove redundant file writing (MarkBind#1090) Bump acorn from 5.7.3 to 5.7.4 (MarkBind#1121) Bump acorn from 7.1.0 to 7.1.1 in /src/lib/markbind (MarkBind#1120) Unify markdown-it parser variants (MarkBind#1056) Remove dynamic include feature (MarkBind#1037) Fix flex shrink not applying in content wrapper (MarkBind#1135) Escape Nunjucks for special tags (MarkBind#1049) Update documentation on icon slot for boxes (MarkBind#1123) Convert code in boxes to code block (MarkBind#1086)
Tejas2805
added a commit
to Tejas2805/markbind
that referenced
this pull request
Mar 25, 2020
* 'master' of https://github.com/MarkBind/markbind: Fix pageNav in tweaking the page structure (MarkBind#1127)
marvinchin
pushed a commit
that referenced
this pull request
Apr 10, 2020
The pageNav for tweaking the page structure is missing filter tags. Let's fix the headings in filter tags and the pageNav so that pageNav display filter tags appropriately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1097
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Documentation update
• [X] Bug fix
What is the rationale for this request?
The pageNav is missing filter tags.
What changes did you make? (Give an overview)
Updated the pageNav for
tweaking the page structureto show filter tags too.Provide some example code that this change will affect:
N.A.
Is there anything you'd like reviewers to focus on?
N.A.
Testing instructions:
Check the preview.
Proposed commit message: (wrap lines at 72 characters)