Add "lpn" error message checking in _ListPlot #1245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocky
force-pushed
the
Add-some-_ListPlot-point-checking
branch
3 times, most recently
from
dde65d8 to
96eb94e
Compare
rocky
added a commit
that referenced
this pull request
Dec 29, 2024
The good stuff from #1245, but alas the thing we were trying to do there can cause an infinite loop in the eval_ListPlot routine. So let's do this part and narrow that PR.
"lpn" is "list of points" checking on ListPlot[] and ListLinePlot[]
_ListPlot[] needs to evaluate its arguements in order to check them! There is this weird place in caching where we were caching the Expression form of a ListExpression. This is something that has been plaguing our code. Finding and fixing these simplifies coding speeds up execution.
Also, substitute for "%(name)" in interrupt handler "show"
rocky
force-pushed
the
Add-some-_ListPlot-point-checking
branch
from
c6337b7 to
effa8b3
Compare
Note that our simplified forms do not *exactly* matches WMA.
rocky
force-pushed
the
Add-some-_ListPlot-point-checking
branch
from
afb5b1e to
ab3c5b7
Compare
Member
Author
|
This PR started just before the last release. It had an infinite loop in it when we had bad input operands. Now that we have an interrupt handler for such situations, especially the "show" and "debugger" commands, it was straightforward to find and fix the bug. |
rocky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"lpn" is "list of points" checking on
ListPlot[]andListLinePlot[]. Fixes #1057