fix: added grace time to client timeout#59
Merged
tegefaulkes merged 4 commits intostagingfrom Jan 29, 2024
Merged
Conversation
This allows for a period of time for the RPCServer to respond if it's handler times out at the same time.
`testProp` is deprecated and `test.prop` is much cleaner to use anyway.
[ci skip]
Contributor
Author
|
This should've never been merged into staging // Wait for server and client to timeout by checking the flag
await new Promise<void>((resolve) => {
const checkFlag = () => {
if (serverTimedOut && clientTimedOut) resolve();
else setTimeout(() => checkFlag(), 10);
};
checkFlag();
});I've removed it along with some other related code. |
This was a very odd thing to add to the API. So I've removed it. Also fixed up some tests relating to that. [ci skip]
Contributor
Author
|
Ready for merge if anyone wants to have a look over it. |
Contributor
Author
|
Most of the general clean up was just syntax and coding style fixes to keep things consistent. I added in some missing type annotation since it's better to be explicit about these things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR fixes the following issues and addresses some general code clean up.
Issues Fixed
testPropusage withtest.prop#58Tasks
testPropusage withtest.prop#58registerOnTimeoutCallbackandonTimeoutCallbackusage.Final checklist