Skip to content

Fix ios crash not crash #4131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomasMizera merged 2 commits into from
Oct 9, 2025
Merged

Fix ios crash not crash #4131

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5a7d86
Fix the double deletion of Qml Engine
Withalion Oct 5, 2025
b47af3f
Fix formatting & Clazy warning
Withalion Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions app/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,9 +573,6 @@ int main( int argc, char *argv[] )
CoreUtils::log( QStringLiteral( "AppState" ), QStringLiteral( "Application has quit" ) );
} );

// this fixes the error dump from C++ defined QML components, when quiting application
QObject::connect( &app, &QCoreApplication::aboutToQuit, &engine, &QQmlEngine::deleteLater );

QObject::connect( &help, &InputHelp::submitReportSuccessful, &lambdaContext, [&notificationModel]()
{
notificationModel.addSuccess( QObject::tr( "Report submitted. Please contact the support" ) );
Expand Down Expand Up @@ -869,6 +866,13 @@ int main( int argc, char *argv[] )
return EXIT_FAILURE;
}

// this fixes the error dump from C++ defined QML components, when quiting application
QObject::connect( &app, &QCoreApplication::aboutToQuit, object, [&]
{
object->deleteLater();
engine.clearComponentCache();
} );

#ifdef Q_OS_IOS
QString logoUrl = "qrc:logo.png";
#else
Expand Down
Loading