Merged
Conversation
Pull Request Test Coverage Report for Build 18282831068Details
💛 - Coveralls |
app/main.cpp
Outdated
|
|
||
| // this fixes the error dump from C++ defined QML components, when quiting application | ||
| QObject::connect(&app, &QCoreApplication::aboutToQuit, [&] { | ||
| object->deleteLater(); |
Contributor
There was a problem hiding this comment.
Nice, How we we even find bug like these, I would have never noticed this bug. Because this does seem like a normal engine exit, because I never knew if you do deleteLater in QQMlEngine it double calls on the stack.
kaustuvpokharel
approved these changes
Oct 5, 2025
tomasMizera
approved these changes
Oct 9, 2025
tomasMizera
added a commit
that referenced
this pull request
Oct 31, 2025
* Target android 15 (#4010) * Remove dep on mobile-sdk (Hello vcpkg) (#3811) Remove dependency on mobile-sdk and system Qt via building of all Mergin Maps deps libraries (QGIS, GDAL, Proj, Qt, and others) by vcpkg system. Changes to CI GitHub workflows, asset management and shared files for platforms. Fixed windows and linux builds. * Fix error dump on quit from QML components (#4104) * Fix/diagnostic log copy able (#4120) * Fix windows EOF breaking preview * Refactor AttributePreviewController * Add new formats for Exiv2 library (#4125) * Merge pull request #4129 from MerginMaps/fix/haptic-vibration Fix haptic vibration * Fix android CI (#4122) * Fix android CI * Update version to 2025.7.0 * Fix apk size * Death to input (#4103) * Fix ios crash not crash (#4131) * Fix the double deletion of Qml Engine * Fix formatting & Clazy warning * Fix forgotten ndk path variable (#4150) * Fix android missing proj & qgis resources on android (#4155) * Sign AABs too --------- Co-authored-by: Peter Petrik <zilolv@gmail.com> Co-authored-by: Kaustuv Pokharel <85729205+kaustuvpokharel@users.noreply.github.com> Co-authored-by: Tomas Mizera <tomas.mizera@lutraconsulting.co.uk>
gabriel-bolbotina
pushed a commit
that referenced
this pull request
Nov 19, 2025
* Fix the double deletion of Qml Engine * Fix formatting & Clazy warning
gabriel-bolbotina
pushed a commit
that referenced
this pull request
Nov 25, 2025
* Fix the double deletion of Qml Engine * Fix formatting & Clazy warning
gabriel-bolbotina
pushed a commit
that referenced
this pull request
Dec 18, 2025
* Fix the double deletion of Qml Engine * Fix formatting & Clazy warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4124
The issue was in the double deletion of
QQmlEnginewhich threw exception on ios. This was caused by previous fix of qml component deletion flow on application flow. The current approach fixes both things.