Skip to content

Fix haptic vibration#4129

Merged
tomasMizera merged 2 commits intodev/2025.7.0from
fix/haptic-vibration
Oct 3, 2025
Merged

Fix haptic vibration#4129
tomasMizera merged 2 commits intodev/2025.7.0from
fix/haptic-vibration

Conversation

@Withalion
Copy link
Contributor

fixes #4047

On some manufacturer devices (Samsung) the native method vibrate(VibrationEffect vibe, VibrationAttributes attributes) is not supported even though the android version should support it. However some other devices don't support vibrate(VibrationEffect vibe) while supporting the previous overload. Thus we use both variants and one execution should trigger the actual vibration.

Android Vibrator API has areEffectsSupported(int... effectIds) method, however on tested devices it returned the same value even though the behavior was different. And even this value is not final as the vibrator should have a fallback vibration even if it returns unsupported.

I was not able to reproduce the sound issue, but @IvaKuklica was. I'll have to investigate further with her.

@Withalion Withalion linked an issue Oct 2, 2025 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Pull Request Test Coverage Report for Build 18207928567

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 19.574%

Files with Coverage Reduction New Missed Lines %
build-mm-db/vcpkg_installed/x64-linux/include/Qt6/QtCore/qmutex.h 1 91.89%
Totals Coverage Status
Change from base Build 18188349751: -0.001%
Covered Lines: 13869
Relevant Lines: 70856

💛 - Coveralls

@tomasMizera tomasMizera merged commit 2072663 into dev/2025.7.0 Oct 3, 2025
9 checks passed
@tomasMizera tomasMizera deleted the fix/haptic-vibration branch October 3, 2025 11:29
tomasMizera added a commit that referenced this pull request Oct 31, 2025
* Target android 15 (#4010)

* Remove dep on mobile-sdk (Hello vcpkg) (#3811)

Remove dependency on mobile-sdk and system Qt via building of all Mergin Maps deps libraries (QGIS, GDAL, Proj, Qt, and others) by vcpkg system. Changes to CI GitHub workflows, asset management and shared files for platforms. Fixed windows and linux builds.

* Fix error dump on quit from QML components (#4104)

* Fix/diagnostic log copy able (#4120)

* Fix windows EOF breaking preview

* Refactor AttributePreviewController

* Add new formats for Exiv2 library (#4125)

* Merge pull request #4129 from MerginMaps/fix/haptic-vibration

Fix haptic vibration

* Fix android CI (#4122)

* Fix android CI

* Update version to 2025.7.0

* Fix apk size

* Death to input (#4103)

* Fix ios crash not crash (#4131)

* Fix the double deletion of Qml Engine

* Fix formatting & Clazy warning

* Fix forgotten ndk path variable (#4150)

* Fix android missing proj & qgis resources on android (#4155)

* Sign AABs too

---------

Co-authored-by: Peter Petrik <zilolv@gmail.com>
Co-authored-by: Kaustuv Pokharel <85729205+kaustuvpokharel@users.noreply.github.com>
Co-authored-by: Tomas Mizera <tomas.mizera@lutraconsulting.co.uk>
gabriel-bolbotina pushed a commit that referenced this pull request Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Touch feedback - no vibration, sound only sometimes

2 participants