Skip to content

Fix error dump on quit from QML components#4104

Merged
Withalion merged 1 commit intodev/2025.7.0from
fix/errors-on-exit
Sep 12, 2025
Merged

Fix error dump on quit from QML components#4104
Withalion merged 1 commit intodev/2025.7.0from
fix/errors-on-exit

Conversation

@Withalion
Copy link
Contributor

fixes #4019

When the application is quit there are lines of errors logged. This started with C++ defined QML components using the QML_ELEMENT signature. The issue was in the chain of deleting objects on quit.

@github-actions
Copy link

Pull Request Test Coverage Report for Build 17672116028

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 86 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.02%) to 19.596%

Files with Coverage Reduction New Missed Lines %
build-mm-db/vcpkg_installed/x64-linux/include/Qt6/QtCore/qmutex.h 1 91.89%
build-mm-db/vcpkg_installed/x64-linux/include/Qt6/QtCore/qstring.h 3 88.02%
mm/core/merginuserinfo.cpp 4 77.12%
mm/core/merginapi.cpp 7 75.22%
mm/app/main.cpp 71 35.54%
Totals Coverage Status
Change from base Build 17492803203: 0.02%
Covered Lines: 13885
Relevant Lines: 70856

💛 - Coveralls

@Withalion Withalion merged commit 82374f7 into dev/2025.7.0 Sep 12, 2025
8 of 9 checks passed
@Withalion Withalion deleted the fix/errors-on-exit branch September 12, 2025 14:52
tomasMizera added a commit that referenced this pull request Oct 31, 2025
* Target android 15 (#4010)

* Remove dep on mobile-sdk (Hello vcpkg) (#3811)

Remove dependency on mobile-sdk and system Qt via building of all Mergin Maps deps libraries (QGIS, GDAL, Proj, Qt, and others) by vcpkg system. Changes to CI GitHub workflows, asset management and shared files for platforms. Fixed windows and linux builds.

* Fix error dump on quit from QML components (#4104)

* Fix/diagnostic log copy able (#4120)

* Fix windows EOF breaking preview

* Refactor AttributePreviewController

* Add new formats for Exiv2 library (#4125)

* Merge pull request #4129 from MerginMaps/fix/haptic-vibration

Fix haptic vibration

* Fix android CI (#4122)

* Fix android CI

* Update version to 2025.7.0

* Fix apk size

* Death to input (#4103)

* Fix ios crash not crash (#4131)

* Fix the double deletion of Qml Engine

* Fix formatting & Clazy warning

* Fix forgotten ndk path variable (#4150)

* Fix android missing proj & qgis resources on android (#4155)

* Sign AABs too

---------

Co-authored-by: Peter Petrik <zilolv@gmail.com>
Co-authored-by: Kaustuv Pokharel <85729205+kaustuvpokharel@users.noreply.github.com>
Co-authored-by: Tomas Mizera <tomas.mizera@lutraconsulting.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants