fix: return class_name + ( import_path ) as class_name#137
Merged
ddelpiano merged 2 commits intodevelopmentfrom Jan 7, 2020
Merged
fix: return class_name + ( import_path ) as class_name#137ddelpiano merged 2 commits intodevelopmentfrom
ddelpiano merged 2 commits intodevelopmentfrom
Conversation
Contributor
Author
|
Is this what you have in mind? |
Member
|
@zsinnema this might do the trick for that issue! Does this also mean that every time we are fetching the class name now we have this version with the path everywhere class name is displayed (many of the grids and detailed views)? If so, it might be an unwanted consequence of the fix. |
Contributor
Author
|
@gidili yes that's the side effect of it. I was doubting to add an extra field in the serializer or replace the class_name value. I have tested a little bit with long import paths and it does show surprisingly good (also in the popups/dialogs) |
Member
ddelpiano
approved these changes
Jan 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
403
MetaCell/geppetto-scidash#403
Changes
Test creation view - some test classes have the same name but different import path
Related issues