Skip to content

fix: return class_name + ( import_path ) as class_name#137

Merged
ddelpiano merged 2 commits intodevelopmentfrom
feature/403
Jan 7, 2020
Merged

fix: return class_name + ( import_path ) as class_name#137
ddelpiano merged 2 commits intodevelopmentfrom
feature/403

Conversation

@zsinnema
Copy link
Contributor

403

MetaCell/geppetto-scidash#403

Changes

Test creation view - some test classes have the same name but different import path

Related issues

@zsinnema zsinnema requested review from ddelpiano and gidili December 18, 2019 10:54
@zsinnema
Copy link
Contributor Author

Is this what you have in mind?

@gidili
Copy link
Member

gidili commented Dec 18, 2019

@zsinnema this might do the trick for that issue!

Does this also mean that every time we are fetching the class name now we have this version with the path everywhere class name is displayed (many of the grids and detailed views)? If so, it might be an unwanted consequence of the fix.

@zsinnema
Copy link
Contributor Author

@gidili yes that's the side effect of it. I was doubting to add an extra field in the serializer or replace the class_name value. I have tested a little bit with long import paths and it does show surprisingly good (also in the popups/dialogs)

@gidili
Copy link
Member

gidili commented Dec 18, 2019

@zsinnema ok, that sounds good, maybe post a screenshot so we can get @rgerkin's feedback too!

We can always go back and add the extra field.

@ddelpiano ddelpiano changed the base branch from master to development January 3, 2020 14:56
@ddelpiano ddelpiano merged commit f4b320b into development Jan 7, 2020
@ddelpiano ddelpiano deleted the feature/403 branch April 21, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants