Skip to content

fix: return class_name + ( import_path ) as class_name #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddelpiano merged 2 commits into from
Jan 7, 2020
Merged

fix: return class_name + ( import_path ) as class_name #137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38606a9
fix: return class_name + ( import_path ) as class_name
zsinnema Dec 18, 2019
1503777
fix: code cleanup
zsinnema Dec 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions scidash/sciunittests/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@


class TestSuiteSerializer(GetOrCreateMixin, WritableNestedModelSerializer):

owner = ScidashUserSerializer(
default=serializers.CurrentUserDefault(), read_only=True
)
Expand All @@ -30,9 +29,17 @@ class Meta:
class TestClassSerializer(
GetByKeyOrCreateMixin, WritableNestedModelSerializer
):
class_name = serializers.SerializerMethodField()
units_name = serializers.CharField(required=False)
key = 'import_path'

def get_class_name(self, obj):
# return class_name + ( first part of import_path )
return obj.class_name + \
(' (' +
'.'.join(obj.import_path.split('.')[0:-1])
+ ')').replace(' ()', '')

class Meta:
model = TestClass
fields = '__all__'
Expand Down Expand Up @@ -132,7 +139,6 @@ class Meta:
class ScoreClassSerializer(
GetByKeyOrCreateMixin, WritableNestedModelSerializer
):

key = 'class_name'

class Meta:
Expand Down