-
-
Notifications
You must be signed in to change notification settings - Fork 126
feat!: add methods to support ERC-4337 accounts #315
Conversation
27017d0 to
d474ec5
Compare
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
|
@SocketSecurity ignore @ethereumjs/rlp@4.0.1 These are transient dependencies and the |
gantunesr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left some minor comments to be resolved before approving
* feat: add UserOperation methods * build: ignore errors from Snap packages * fix: fix return type of `prepareUserOperation` * chore: enable lcov coverage * test: add missing unit tests * chore: update `yarn.lock` * chore: apply linter * chore: update @metamask/keyring-api version to 2.0.0
* feat: add UserOperation methods * build: ignore errors from Snap packages * fix: fix return type of `prepareUserOperation` * chore: enable lcov coverage * test: add missing unit tests * chore: update `yarn.lock` * chore: apply linter * chore: update @metamask/keyring-api version to 2.0.0
## Description **Depends on:** - [x] <MetaMask/keyring-api#213> - [x] <MetaMask/KeyringController#315> - [x] <#3617> This PR adds the following new methods available in the `EthKeyring` interface: - `prepareUserOperation` - `patchUserOperation` - `signUserOperation` See the [PR](MetaMask/keyring-api#213) in the `keyring-api` for more details. ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc) - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
Description
Depends on:
This PR adds the following new methods available in the
EthKeyringinterface:prepareUserOperationpatchUserOperationsignUserOperationSee the PR in the
keyring-apifor more details.BREAKING: This PR replaces the
Keyringinterface from@metamask/utilswith theEthKeyringinterface from@metamask/keyring-api.Checklist