Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

Conversation

@danroc
Copy link
Contributor

@danroc danroc commented Dec 11, 2023

This PR merges the recent changes from main into bump-coverage.

danroc and others added 2 commits December 11, 2023 10:22
* feat: add UserOperation methods

* build: ignore errors from Snap packages

* fix: fix return type of `prepareUserOperation`

* chore: enable lcov coverage

* test: add missing unit tests

* chore: update `yarn.lock`

* chore: apply linter

* chore: update @metamask/keyring-api version to 2.0.0
@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
eslint-plugin-import 2.29.0...2.26.0 None +3/-1 1.12 MB ljharb

@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Bin script confusion @ethereumjs/rlp 4.0.1
  • Bin Script: rlp
Bin script confusion @ethereumjs/rlp 5.0.1
  • Bin Script: rlp
Bin script confusion rlp 2.2.7
  • Bin Script: rlp

Next steps

What is bin script confusion?

This package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack

Consider removing one of the conflicting packages. Packages should only export bin scripts with their name

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore @ethereumjs/rlp@4.0.1
  • @SocketSecurity ignore @ethereumjs/rlp@5.0.1
  • @SocketSecurity ignore rlp@2.2.7

@danroc danroc marked this pull request as ready for review December 11, 2023 10:31
@danroc danroc requested a review from a team as a code owner December 11, 2023 10:31
Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Alternatively, we can rebase #309 before merging this in, so that #309 would already be up to date with main. But ways both work I guess

@danroc danroc merged commit e690c7e into bump-coverage Dec 13, 2023
@danroc danroc deleted the dr/bump-coverage branch December 13, 2023 15:38
mikesposito pushed a commit that referenced this pull request Jan 15, 2024
* feat: add UserOperation methods

* build: ignore errors from Snap packages

* fix: fix return type of `prepareUserOperation`

* chore: enable lcov coverage

* test: add missing unit tests

* chore: update `yarn.lock`

* chore: apply linter

* chore: update @metamask/keyring-api version to 2.0.0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants