BREAKING: Move SubjectMetadataController to permission-controller package
#1234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
changed the title
SubjectMetadataController to permission-controller package
FrederikBolding
changed the title
SubjectMetadataController to permission-controller packageSubjectMetadataController to permission-controller package
Mrtenz
reviewed
Apr 20, 2023
Member
Mrtenz
left a comment
Mrtenz
left a comment
There was a problem hiding this comment.
You may have to run yarn generate-dependency-graph.
Member
Author
Gudahtt
approved these changes
Apr 20, 2023
Merged
FrederikBolding
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Oct 9, 2023
## **Description** The `SubjectMetadataController` and its utilities were moved to the `permission-controller` package a while back (MetaMask/core#1234). This PR removes usage of the old deprecated package in favor of `permission-controller`. There should be no functionality changes by this change.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…ackage (#1234) * Move SubjectMetadataController to permission-controller package * Update imports * Update dep graph
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…ackage (#1234) * Move SubjectMetadataController to permission-controller package * Update imports * Update dep graph
k-g-j
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Nov 1, 2023
## **Description** The `SubjectMetadataController` and its utilities were moved to the `permission-controller` package a while back (MetaMask/core#1234). This PR removes usage of the old deprecated package in favor of `permission-controller`. There should be no functionality changes by this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move
SubjectMetadataControllerto permission-controller package since these two packages are heavily coupled.This also prevents circular dependency issues in the future if we want to access
SubjectMetadataControllerdata withinPermissionControllerChanges
SubjectMetadataControllertopermission-controllerpackagesubject-metadata-controllerpackageChecklist