Remove usage of subject-metadata-controller package

[FrederikBolding]

Description

The SubjectMetadataController and its utilities were moved to the permission-controller package a while back (MetaMask/core#1234). This PR removes usage of the old deprecated package in favor of permission-controller. There should be no functionality changes by this change.

[socket-security]

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
@metamask/controller-utils	3.4.0...5.0.1	None	+0/-0	111 kB	metamaskbot

🚮 Removed packages: @metamask/subject-metadata-controller@2.0.0

[metamaskbot]

Builds ready [5db93ee]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6, 7
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (734 ± 403 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	95	155	119	19	9
		domContentLoaded	70	164	107	26	12
		load	88	1939	734	839	403
		domInteractive	70	164	107	26	12

Bundle size diffs [🚀 Bundle size reduced!]

• background: -420 Bytes (-0.01%)
• ui: -90 Bytes (-0.00%)
• common: -12.18 KiB (-0.25%)

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (487c079) 68.64% compared to head (5db93ee) 68.65%.
Report is 2 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #21254   +/-   ##
========================================
  Coverage    68.64%   68.65%           
========================================
  Files         1017     1017           
  Lines        40792    40801    +9     
  Branches     10896    10893    -3     
========================================
+ Hits         28001    28008    +7     
- Misses       12791    12793    +2     

Files	Coverage Δ
app/scripts/metamask-controller.js	54.04% <100.00%> (+0.11%)	⬆️
app/scripts/migrations/069.js	100.00% <ø> (ø)
...ect-header/permissions-connect-header.component.js	90.00% <ø> (ø)
ui/hooks/useOriginMetadata.js	78.57% <ø> (ø)
...rmissions-connect/permissions-connect.component.js	2.41% <ø> (ø)
...rmissions-connect/permissions-connect.container.js	6.45% <ø> (ø)
ui/selectors/selectors.js	86.84% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.