chore(controller-utils): move @metamask/eth-query from deps to devDeps #1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
force-pushed
the
deps-utils-move-eth-query-to-devDeps
branch
from
3fe8256 to
6abda4d
Compare
3 tasks
FrederikBolding
added a commit
that referenced
this pull request
Nov 24, 2023
## Explanation In #1815, `@metamask/eth-query` was moved from deps to devDeps under the assumption that this would be safe because the dependency is only used for types. This assumption is false as the type import is shipped in `utils.d.ts` and will be attempted to be resolved in packages that consume the library. This in turn causes build errors like: `Error: node_modules/@metamask/controller-utils/dist/util.d.ts(2,27): error TS2307: Cannot find module '@metamask/eth-query' or its corresponding type declarations.` ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/controller-utils` - **Fixed**: Move `@metamask/eth-query` from devDependencies to dependencies ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
core/packages/controller-utils/src/util.ts
Line 1 in 2e95c89
References
Changelog
@metamask/controller-utils@metamask/eth-queryfrom dependencies to devDependenciesChecklist