Move eth-query back from devDeps to deps
#3578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
In #1815,
@metamask/eth-querywas moved from deps to devDeps under the assumption that this would be safe because the dependency is only used for types. This assumption is false as the type import is shipped inutils.d.tsand will be attempted to be resolved in packages that consume the library. This in turn causes build errors like:Error: node_modules/@metamask/controller-utils/dist/util.d.ts(2,27): error TS2307: Cannot find module '@metamask/eth-query' or its corresponding type declarations.Changelog
@metamask/controller-utils@metamask/eth-queryfrom devDependencies to dependenciesChecklist