Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Nov 24, 2023

Explanation

In #1815, @metamask/eth-query was moved from deps to devDeps under the assumption that this would be safe because the dependency is only used for types. This assumption is false as the type import is shipped in utils.d.ts and will be attempted to be resolved in packages that consume the library. This in turn causes build errors like: Error: node_modules/@metamask/controller-utils/dist/util.d.ts(2,27): error TS2307: Cannot find module '@metamask/eth-query' or its corresponding type declarations.

Changelog

@metamask/controller-utils

  • Fixed: Move @metamask/eth-query from devDependencies to dependencies

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@FrederikBolding FrederikBolding requested a review from a team as a code owner November 24, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants