Skip to content

Conversation

@montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Oct 24, 2023

Explanation

This PR adds getAccount action to the AccountsController.

References

Changelog

@metamask/package-a

  • ADDED: adds getAccount action to the AccountsController

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@montelaidev
Copy link
Contributor Author

@metamaskbot publish-preview

@montelaidev montelaidev force-pushed the feat/add-getAccountAction-to-AccountsController branch from e3b05ea to 578eb39 Compare October 24, 2023 15:35
@montelaidev
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "3.0.0-preview.578eb39",
  "@metamask-previews/address-book-controller": "3.1.4-preview.578eb39",
  "@metamask-previews/announcement-controller": "4.0.3-preview.578eb39",
  "@metamask-previews/approval-controller": "4.0.1-preview.578eb39",
  "@metamask-previews/assets-controllers": "16.0.0-preview.578eb39",
  "@metamask-previews/base-controller": "3.2.3-preview.578eb39",
  "@metamask-previews/composable-controller": "3.0.3-preview.578eb39",
  "@metamask-previews/controller-utils": "5.0.2-preview.578eb39",
  "@metamask-previews/ens-controller": "6.0.0-preview.578eb39",
  "@metamask-previews/eth-json-rpc-provider": "2.2.0-preview.578eb39",
  "@metamask-previews/gas-fee-controller": "9.0.0-preview.578eb39",
  "@metamask-previews/keyring-controller": "8.0.3-preview.578eb39",
  "@metamask-previews/logging-controller": "1.0.4-preview.578eb39",
  "@metamask-previews/message-manager": "7.3.5-preview.578eb39",
  "@metamask-previews/name-controller": "3.0.1-preview.578eb39",
  "@metamask-previews/network-controller": "15.0.0-preview.578eb39",
  "@metamask-previews/notification-controller": "3.1.3-preview.578eb39",
  "@metamask-previews/permission-controller": "5.0.0-preview.578eb39",
  "@metamask-previews/phishing-controller": "7.0.1-preview.578eb39",
  "@metamask-previews/polling-controller": "0.2.0-preview.578eb39",
  "@metamask-previews/preferences-controller": "4.4.3-preview.578eb39",
  "@metamask-previews/queued-request-controller": "0.0.0-preview.578eb39",
  "@metamask-previews/rate-limit-controller": "3.0.3-preview.578eb39",
  "@metamask-previews/selected-network-controller": "3.0.0-preview.578eb39",
  "@metamask-previews/signature-controller": "6.1.3-preview.578eb39",
  "@metamask-previews/transaction-controller": "15.0.0-preview.578eb39"
}

@montelaidev montelaidev requested a review from danroc November 2, 2023 10:50
@montelaidev montelaidev marked this pull request as ready for review November 4, 2023 01:33
@montelaidev montelaidev requested a review from a team as a code owner November 4, 2023 01:33
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@montelaidev montelaidev merged commit 20011c4 into main Jan 22, 2024
@montelaidev montelaidev deleted the feat/add-getAccountAction-to-AccountsController branch January 22, 2024 08:09
Gudahtt added a commit that referenced this pull request Jan 22, 2024
…roller-in-sync-with-keyrings

* origin/main:
  chore(deps): bump @metamask/eth-keyring-controller from 17.0.0 to 17.0.1 (#3805)
  fix: custody keyring name (#3803)
  chore: update dependencies for `@metamask/accounts-controller` (#3747)
  fix: quick succession of submit password causing Accounts Controller state to be cleared (#3802)
  feat: add methods to support ERC-4337 accounts (#3602)
  feat: add getAccount action to AccountsController (#1892)
Gudahtt added a commit that referenced this pull request Jan 22, 2024
…roller-in-sync-with-keyrings

* origin/main:
  chore(deps): bump @metamask/eth-keyring-controller from 17.0.0 to 17.0.1 (#3805)
  fix: custody keyring name (#3803)
  chore: update dependencies for `@metamask/accounts-controller` (#3747)
  fix: quick succession of submit password causing Accounts Controller state to be cleared (#3802)
  feat: add methods to support ERC-4337 accounts (#3602)
  feat: add getAccount action to AccountsController (#1892)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants