Skip to content

fix: quick succession of submit password causing Accounts Controller state to be cleared #3802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
montelaidev merged 4 commits into from
Jan 22, 2024
Merged

fix: quick succession of submit password causing Accounts Controller state to be cleared #3802

montelaidev merged 4 commits into from
Jan 22, 2024

Conversation

@montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Jan 20, 2024

Explanation

This PR fixes the edge case that leads to the reset of the Accounts Controller state. The accounts controller listens to the keyring controller state change, when the extension client executes two submit passwords in succession, there is a race condition where the keyring controller would empty its keyring state causing the accounts controller to clear its state.

References

For example:

Changelog

@metamask/accounts-controller

  • CHANGED: onKeyringState only triggers when the keyring controller is unlocked and has keyrings.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • [] I've highlighted breaking changes using the "BREAKING" category above as appropriate

@montelaidev
fix: submit password case that leads to keyring controller clearing k…
9913390 
…eyrings can causing accounts controller to also clear its state
@montelaidev montelaidev self-assigned this Jan 20, 2024
@montelaidev montelaidev requested a review from a team as a code owner January 20, 2024 09:30
@montelaidev montelaidev changed the title fix: submit password case that leads to keyring controller clearing k… Fix: Quick Succession of pubmit password case causing Accounts Controller State to be cleared. Jan 20, 2024
@montelaidev montelaidev requested a review from danroc January 20, 2024 09:32
@montelaidev montelaidev changed the title Fix: Quick Succession of pubmit password case causing Accounts Controller State to be cleared. Fix: Quick Succession of submit password case causing Accounts Controller State to be cleared. Jan 22, 2024
@danroc danroc changed the title Fix: Quick Succession of submit password case causing Accounts Controller State to be cleared. Fix: Quick Succession of submit password case causing Accounts Controller State to be cleared Jan 22, 2024
@danroc danroc changed the title Fix: Quick Succession of submit password case causing Accounts Controller State to be cleared fix: quick Succession of submit password case causing Accounts Controller State to be cleared Jan 22, 2024
@danroc danroc changed the title fix: quick Succession of submit password case causing Accounts Controller State to be cleared fix: quick succession of submit password case causing Accounts Controller state to be cleared Jan 22, 2024
@danroc danroc changed the title fix: quick succession of submit password case causing Accounts Controller state to be cleared fix: quick succession of submit password causing Accounts Controller state to be cleared Jan 22, 2024
@montelaidev montelaidev merged commit b74c48d into main Jan 22, 2024
@montelaidev montelaidev deleted the fix/ap-215-fix-submit-password-case branch January 22, 2024 12:45
Gudahtt added a commit that referenced this pull request Jan 22, 2024
@Gudahtt
Merge remote-tracking branch 'origin/main' into keep-preferences-cont…
abdaeea 
…roller-in-sync-with-keyrings

* origin/main:
  chore(deps): bump @metamask/eth-keyring-controller from 17.0.0 to 17.0.1 (#3805)
  fix: custody keyring name (#3803)
  chore: update dependencies for `@metamask/accounts-controller` (#3747)
  fix: quick succession of submit password causing Accounts Controller state to be cleared (#3802)
  feat: add methods to support ERC-4337 accounts (#3602)
  feat: add getAccount action to AccountsController (#1892)
Gudahtt added a commit that referenced this pull request Jan 22, 2024
@Gudahtt
Merge remote-tracking branch 'origin/main' into keep-preferences-cont…
ee153a6 
…roller-in-sync-with-keyrings

* origin/main:
  chore(deps): bump @metamask/eth-keyring-controller from 17.0.0 to 17.0.1 (#3805)
  fix: custody keyring name (#3803)
  chore: update dependencies for `@metamask/accounts-controller` (#3747)
  fix: quick succession of submit password causing Accounts Controller state to be cleared (#3802)
  feat: add methods to support ERC-4337 accounts (#3602)
  feat: add getAccount action to AccountsController (#1892)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danroc danroc danroc approved these changes

Assignees

@montelaidev montelaidev

Labels

team-accounts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@montelaidev @danroc