Update @metamask/eslint-config from v3 to v4.1.0
#344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update includes the update from `eslint` v6 to v7. In this release the Node.js-specific rules were broken out into a separate plugin (`eslint-plugin-node`), which is now also required. Any broken rules have been temporarily disabled, to be addressed in a future PR.
rickycodes
approved these changes
Feb 11, 2021
rickycodes
added a commit
that referenced
this pull request
Feb 18, 2021
…ba into feature/migrate-to-etherscan * 'feature/migrate-to-etherscan' of github.com:MetaMask/gaba: Update `sinon` and `@types/sinon` to latest versions (#352) Fix `tsconfig.json` indentation (#355) Replace `fetch-mock` with `nock` (#340) Update `ethereumjs-wallet` from v0.6.5 to v1.0.1 (#347) Add `babel-runtime` dependency required by `ethjs-query` (#341) Update `@metamask/eslint-config` from v3 to v4.1.0 (#344) Add `docs` to list of ignored eslint patterns (#345) Update `uuid` from `v3.3.3` to `v8.3.2` (#346) Update approval controller test import (#339) Add Dependabot config (#343) Update `typedoc` (#342) Remove unused test module (#338) Replace `await-semaphore` with `async-mutex` (#334) Update `eth-json-rpc-filters` in lockfile (#336)
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
This update includes the update from `eslint` v6 to v7. In this release the Node.js-specific rules were broken out into a separate plugin (`eslint-plugin-node`), which is now also required. Any broken rules have been temporarily disabled, to be addressed in a future PR.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
This update includes the update from `eslint` v6 to v7. In this release the Node.js-specific rules were broken out into a separate plugin (`eslint-plugin-node`), which is now also required. Any broken rules have been temporarily disabled, to be addressed in a future PR.
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
…ut` (#346) The timeout recorder utility used in unit tests could accidentally allow a test to insert synchronous code after a `setTimeout` was resolved. The methods to allow waiting for a pending `setTimeout` to execute didn't clear pending Promises, so the code following those calls in a test would run _immediately_ after the timeout was resolved, which normally would not be possible for an external caller. The code-under-test may (correctly) assume that a caller cannot run code after a `setTimeout` resolves before it can. Tests that violate this assumption unintentionally serve no practical purpose, and may be confusing for contributors or require complex workarounds. This exact problem cropped up in another draft PR currently open, #344. To prevent this, pending Promises are resolved before returning when waiting for a `setTimeout` to resolve. Additionally, pending Promises are now also resolved before the `setTimeout` callback, again to better reflect what would happen in a real scenario. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Ensure the test timeout recorder resolves pending timers/promises after executing a queued setTimeout callback to avoid synchronous code running immediately after. > > - **Tests**: > - **`tests/recordCallsToSetTimeout.ts`**: > - `SetTimeoutRecorder.next` and `nextMatchingDuration` now await the internal promise and then call `jest.runOnlyPendingTimersAsync()` to flush pending timers/promises. > - Prevents tests from inserting synchronous code immediately after a `setTimeout` callback executes. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 501ad5c6f10ce68ff9eafb09e403c8b63b932e37. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update includes the update from
eslintv6 to v7. In this release the Node.js-specific rules were broken out into a separate plugin (eslint-plugin-node), which is now also required.Any broken rules have been temporarily disabled, to be addressed in a future PR.