Update sinon and @types/sinon to latest versions
#352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sinon` has been updated from v7 to v9. There have been no breaking changes that affect our usage. The types we were using were _far_ behind though, so updating those has revealed pre-existing mistakes in how we were using `sinon` in a few places. For one of the type errors, I replaced a `window.fetch` mock with `nock`, as that seemed like the simplest way to fix the type error.
Gudahtt
force-pushed
the
update-sinon
branch
from
d4fba20 to
117c428
Compare
kumavis
approved these changes
Feb 18, 2021
Member
kumavis
left a comment
kumavis
left a comment
There was a problem hiding this comment.
sinon me up for this excellent improvement
rickycodes
added a commit
that referenced
this pull request
Feb 18, 2021
…ba into feature/migrate-to-etherscan * 'feature/migrate-to-etherscan' of github.com:MetaMask/gaba: Update `sinon` and `@types/sinon` to latest versions (#352) Fix `tsconfig.json` indentation (#355) Replace `fetch-mock` with `nock` (#340) Update `ethereumjs-wallet` from v0.6.5 to v1.0.1 (#347) Add `babel-runtime` dependency required by `ethjs-query` (#341) Update `@metamask/eslint-config` from v3 to v4.1.0 (#344) Add `docs` to list of ignored eslint patterns (#345) Update `uuid` from `v3.3.3` to `v8.3.2` (#346) Update approval controller test import (#339) Add Dependabot config (#343) Update `typedoc` (#342) Remove unused test module (#338) Replace `await-semaphore` with `async-mutex` (#334) Update `eth-json-rpc-filters` in lockfile (#336)
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
`sinon` has been updated from v7 to v9. There have been no breaking changes that affect our usage. The types we were using were _far_ behind though, so updating those has revealed pre-existing mistakes in how we were using `sinon` in a few places. For one of the type errors, I replaced a `window.fetch` mock with `nock`, as that seemed like the simplest way to fix the type error.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
`sinon` has been updated from v7 to v9. There have been no breaking changes that affect our usage. The types we were using were _far_ behind though, so updating those has revealed pre-existing mistakes in how we were using `sinon` in a few places. For one of the type errors, I replaced a `window.fetch` mock with `nock`, as that seemed like the simplest way to fix the type error.
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
We're migrating this to `/core` tomorrow. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > <sup>[Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) is generating a summary for commit 12ea2d39ea956bfe9e357e09e33639067e24d705. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sinonhas been updated from v7 to v9. There have been no breaking changes that affect our usage.The types we were using were far behind though, so updating those has revealed pre-existing mistakes in how we were using
sinonin a few places.For one of the type errors, I replaced a
window.fetchmock withnock, as that seemed like the simplest way to fix the type error.