TransactionController: providerConfig -> selectedNetworkClientId #4357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `providerConfig` state property is being removed from NetworkController. Currently this property is used in TransactionController to get the currently selected chain, but `selectedNetworkClientId` can be used instead. This commit makes that transition so that we can fully drop `providerConfig`.
3 tasks
MajorLift
reviewed
Jun 7, 2024
packages/transaction-controller/src/TransactionController.test.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/TransactionController.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
legobeat
pushed a commit
that referenced
this pull request
Jun 11, 2024
The `providerConfig` state property is being removed from NetworkController. Currently this property is used in TransactionController to get the currently selected chain, but `selectedNetworkClientId` can be used instead. This commit makes that transition so that we can fully drop `providerConfig`. --------- Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
legobeat
pushed a commit
that referenced
this pull request
Jun 11, 2024
The `providerConfig` state property is being removed from NetworkController. Currently this property is used in TransactionController to get the currently selected chain, but `selectedNetworkClientId` can be used instead. This commit makes that transition so that we can fully drop `providerConfig`. --------- Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
legobeat
pushed a commit
that referenced
this pull request
Jun 11, 2024
The `providerConfig` state property is being removed from NetworkController. Currently this property is used in TransactionController to get the currently selected chain, but `selectedNetworkClientId` can be used instead. This commit makes that transition so that we can fully drop `providerConfig`. --------- Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
providerConfigstate property is being removed from NetworkController. Currently this property is used in TransactionController to get the currently selected chain, butselectedNetworkClientIdcan be used instead. This commit makes that transition so that we can fully dropproviderConfig.References
Progresses #4185.
Changelog
(There should be no functional changes, so no changelog updates are needed.)
Checklist