Fix permission-controller lint violations

[mcmire]

Explanation

There are some permission-controller tests which attempt to push an async middleware function onto an engine. Although this works in practice, @typescript-eslint balks at this, because the type for JsonRpcEngine.push says it takes a JsonRpcMiddleware, and a JsonRpcMiddleware has a return type of void, not Promise<void>. We could change that return type to void | Promise<void> but that would cause other changes we may not want to make. So this commit merely ignores the lint violations. This should be safe because JsonRpcEngine doesn't await middleware anyway.

Interestingly, the lint violations caused by this discrepancy only appear locally and not on CI. I am not sure why this is.

References

Also see: #4521

Changelog

(No consumer-facing changes to log)

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate

[mcmire]

@rekmarks You may be interested in this PR since you made some changes to the permission controller recently. Are you able to replicate these lint violations?

[rekmarks]

@mcmire LGTM, but beware that something fishy is going on: #4540

I can't observe the failures you're seeing. I thought "I'm just having some local issue, I'll ignore it", but it seems there's actually something wrong.