Skip to content

Fix permission-controller lint violations #4537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcmire merged 2 commits into from
Jul 18, 2024
Merged

Fix permission-controller lint violations #4537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e5b434
Fix permission-controller lint violations
mcmire Jul 17, 2024
9d4af5a
Merge branch 'main' into fix-permission-controller-lint-violations
mcmire Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/permission-controller/src/rpc-methods/getPermissions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,16 @@ describe('getPermissions RPC method', () => {

const engine = new JsonRpcEngine();
engine.push(
async (
(
req: JsonRpcRequest<[]>,
res: PendingJsonRpcResponse<PermissionConstraint[]>,
next,
end,
) => {
await implementation(req, res, next, end, {
// We intentionally do not await this promise; JsonRpcEngine won't await
// middleware anyway.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
implementation(req, res, next, end, {
getPermissionsForOrigin: mockGetPermissionsForOrigin,
});
},
Expand All @@ -44,13 +47,16 @@ describe('getPermissions RPC method', () => {

const engine = new JsonRpcEngine();
engine.push(
async (
(
req: JsonRpcRequest<[]>,
res: PendingJsonRpcResponse<PermissionConstraint[]>,
next,
end,
) => {
await implementation(req, res, next, end, {
// We intentionally do not await this promise; JsonRpcEngine won't await
// middleware anyway.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
implementation(req, res, next, end, {
getPermissionsForOrigin: mockGetPermissionsForOrigin,
});
},
Expand Down
14 changes: 10 additions & 4 deletions packages/permission-controller/src/rpc-methods/requestPermissions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,11 @@ describe('requestPermissions RPC method', () => {

const engine = new JsonRpcEngine();
engine.push<[RequestedPermissions], PermissionConstraint[]>(
async (req, res, next, end) => {
await implementation(req, res, next, end, {
(req, res, next, end) => {
// We intentionally do not await this promise; JsonRpcEngine won't await
// middleware anyway.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
implementation(req, res, next, end, {
requestPermissionsForOrigin: mockRequestPermissionsForOrigin,
});
},
Expand Down Expand Up @@ -102,8 +105,11 @@ describe('requestPermissions RPC method', () => {

const engine = new JsonRpcEngine();
engine.push<[RequestedPermissions], PermissionConstraint[]>(
async (req, res, next, end) => {
await implementation(req, res, next, end, {
(req, res, next, end) => {
// We intentionally do not await this promise; JsonRpcEngine won't await
// middleware anyway.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
implementation(req, res, next, end, {
requestPermissionsForOrigin: mockRequestPermissionsForOrigin,
});
},
Expand Down
35 changes: 25 additions & 10 deletions packages/permission-controller/src/rpc-methods/revokePermissions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,11 @@ describe('revokePermissions RPC method', () => {
const mockRevokePermissionsForOrigin = jest.fn();

const engine = new JsonRpcEngine();
engine.push<RevokePermissionArgs, null>(async (req, res, next, end) => {
await implementation(req, res, next, end, {
engine.push<RevokePermissionArgs, null>((req, res, next, end) => {
// We intentionally do not await this promise; JsonRpcEngine won't await
// middleware anyway.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
implementation(req, res, next, end, {
revokePermissionsForOrigin: mockRevokePermissionsForOrigin,
});
});
Expand Down Expand Up @@ -57,8 +60,11 @@ describe('revokePermissions RPC method', () => {
const mockRevokePermissionsForOrigin = jest.fn();

const engine = new JsonRpcEngine();
engine.push<RevokePermissionArgs, null>(async (req, res, next, end) => {
await implementation(req, res, next, end, {
engine.push<RevokePermissionArgs, null>((req, res, next, end) => {
// We intentionally do not await this promise; JsonRpcEngine won't await
// middleware anyway.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
implementation(req, res, next, end, {
revokePermissionsForOrigin: mockRevokePermissionsForOrigin,
});
});
Expand Down Expand Up @@ -91,8 +97,11 @@ describe('revokePermissions RPC method', () => {
const mockRevokePermissionsForOrigin = jest.fn();

const engine = new JsonRpcEngine();
engine.push<RevokePermissionArgs, null>(async (req, res, next, end) => {
await implementation(req, res, next, end, {
engine.push<RevokePermissionArgs, null>((req, res, next, end) => {
// We intentionally do not await this promise; JsonRpcEngine won't await
// middleware anyway.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
implementation(req, res, next, end, {
revokePermissionsForOrigin: mockRevokePermissionsForOrigin,
});
});
Expand Down Expand Up @@ -125,8 +134,11 @@ describe('revokePermissions RPC method', () => {
const mockRevokePermissionsForOrigin = jest.fn();

const engine = new JsonRpcEngine();
engine.push<RevokePermissionArgs, null>(async (req, res, next, end) => {
await implementation(req, res, next, end, {
engine.push<RevokePermissionArgs, null>((req, res, next, end) => {
// We intentionally do not await this promise; JsonRpcEngine won't await
// middleware anyway.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
implementation(req, res, next, end, {
revokePermissionsForOrigin: mockRevokePermissionsForOrigin,
});
});
Expand Down Expand Up @@ -158,8 +170,11 @@ describe('revokePermissions RPC method', () => {
const mockRevokePermissionsForOrigin = jest.fn();

const engine = new JsonRpcEngine();
engine.push<RevokePermissionArgs, null>(async (req, res, next, end) => {
await implementation(req, res, next, end, {
engine.push<RevokePermissionArgs, null>((req, res, next, end) => {
// We intentionally do not await this promise; JsonRpcEngine won't await
// middleware anyway.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
implementation(req, res, next, end, {
revokePermissionsForOrigin: mockRevokePermissionsForOrigin,
});
});
Expand Down