test: fix transaction controller integration tests with nonce tracker 6

[matthewwalsh0]

Explanation

Fix the TransactionController integration tests with version 6.0.0 of @metamask/nonce-tracker.

This version of the nonce tracker constructs a new Web3Provider instance every time a eth_getTransactionCount call is required, this is needed in order to support the proxy provider which can dynamically point to different networks.

This Web3Provider extends the JsonRpcProvider whose constructor has the side effect of creating a timeout to determine the chain ID, if not provided in the constructor. When calling getTransactionCount on this provider, it first awaits the network being identified as a result of the timeout.

https://github.com/ethers-io/ethers.js/blob/v5.7.2/packages/providers/src.ts/json-rpc-provider.ts#L416

https://github.com/ethers-io/ethers.js/blob/v5.7.2/packages/providers/src.ts/base-provider.ts#L1461

Since the integration tests use fake timers, some of them were hanging when generating a nonce since an additional tick was required to process this constructor network timeout.

References

Related to #2668

Changelog

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate

[socket-security]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/nonce-tracker@6.0.0	None	0	29.1 kB	lgbot

View full report↗︎