deps(transaction-controller): @metamask/nonce-tracker@^5.0.0->^6.0.0 #4327

legobeat · 2024-05-28T08:23:43Z

Explanation

Updates @metamask/nonce-tracker to remove need for @ts-expect-error around the blockTracker type.

~~Also updates transaction-controller tests to reset providers and block trackers between each test.~~

The tests should be failing due to a combination of bug fixed in fix(transaction-controller): Return global ethQuery when !isMultichainEnabled #4390 and bug fixed in @metamask/nonce-tracker 6. Merging fix(transaction-controller): Return global ethQuery when !isMultichainEnabled #4390 and testfix(transaction-controller): Refactor provider setup to provide correct providers and tracker #4391 will make tests pass here.

References

Failing tests fixed by: fix(transaction-controller): Return global ethQuery when !isMultichainEnabled #4390
Related testfix and refactor in: testfix(transaction-controller): Refactor provider setup to provide correct providers and tracker #4391
Follow-up to: deps(network-controller): eth-block-tracker@8 -> @metamask/eth-block-tracker@9 #4309
Related: Retrieve global provider and block tracker dynamically #4004
~~dependabot version: chore(deps): bump @metamask/nonce-tracker from 5.0.0 to 6.0.0 #4329~~

Changelog

`@metamask/network-controller`

CHANGED: Update @metamask/eth-block-tracker from ^9.0.2 to ^9.0.3

`@metamask/transaction-controller`

CHANGED: Update @metamask/nonce-tracker from ^5.0.0 to ^6.0.0

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've highlighted breaking changes using the "BREAKING" category above as appropriate

mcmire

Nice!

legobeat · 2024-06-10T17:45:50Z

@metamaskbot publish-preview

legobeat · 2024-06-10T18:38:23Z

Prerelease builds:

{
  "@metamask-previews/accounts-controller": "16.0.0-preview-0f65e9e",
  "@metamask-previews/address-book-controller": "5.0.0-preview-0f65e9e",
  "@metamask-previews/announcement-controller": "7.0.0-preview-0f65e9e",
  "@metamask-previews/approval-controller": "7.0.0-preview-0f65e9e",
  "@metamask-previews/assets-controllers": "32.0.0-preview-0f65e9e",
  "@metamask-previews/base-controller": "6.0.0-preview-0f65e9e",
  "@metamask-previews/build-utils": "3.0.0-preview-0f65e9e",
  "@metamask-previews/chain-controller": "0.0.0-preview-0f65e9e",
  "@metamask-previews/composable-controller": "7.0.0-preview-0f65e9e",
  "@metamask-previews/controller-utils": "11.0.0-preview-0f65e9e",
  "@metamask-previews/ens-controller": "12.0.0-preview-0f65e9e",
  "@metamask-previews/eth-json-rpc-provider": "4.0.0-preview-0f65e9e",
  "@metamask-previews/gas-fee-controller": "17.0.0-preview-0f65e9e",
  "@metamask-previews/json-rpc-engine": "9.0.0-preview-0f65e9e",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.0-preview-0f65e9e",
  "@metamask-previews/keyring-controller": "17.0.0-preview-0f65e9e",
  "@metamask-previews/logging-controller": "5.0.0-preview-0f65e9e",
  "@metamask-previews/message-manager": "10.0.0-preview-0f65e9e",
  "@metamask-previews/name-controller": "8.0.0-preview-0f65e9e",
  "@metamask-previews/network-controller": "19.0.0-preview-0f65e9e",
  "@metamask-previews/notification-controller": "6.0.0-preview-0f65e9e",
  "@metamask-previews/permission-controller": "10.0.0-preview-0f65e9e",
  "@metamask-previews/permission-log-controller": "3.0.0-preview-0f65e9e",
  "@metamask-previews/phishing-controller": "10.0.0-preview-0f65e9e",
  "@metamask-previews/polling-controller": "8.0.0-preview-0f65e9e",
  "@metamask-previews/preferences-controller": "13.0.0-preview-0f65e9e",
  "@metamask-previews/profile-sync-controller": "0.0.0-preview-0f65e9e",
  "@metamask-previews/queued-request-controller": "0.12.0-preview-0f65e9e",
  "@metamask-previews/rate-limit-controller": "6.0.0-preview-0f65e9e",
  "@metamask-previews/selected-network-controller": "15.0.1-preview-0f65e9e",
  "@metamask-previews/signature-controller": "18.0.0-preview-0f65e9e",
  "@metamask-previews/transaction-controller": "32.0.0-preview-0f65e9e",
  "@metamask-previews/user-operation-controller": "12.0.0-preview-0f65e9e"
}

extension draft with preview-build for testing: fix: tx-controller / nonce-tracker fix metamask-extension#25188

## Explanation Please see https://github.com/MetaMask/MetaMask-planning/issues/2668 ## References See: https://github.com/MetaMask/MetaMask-planning/issues/2668 Unblocks: #4327 ## Changelog No user facing changes ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Jiexi Luan <jiexiluan@gmail.com> Co-authored-by: Derek Brans <dbrans@gmail.com>

## Explanation Please see MetaMask/MetaMask-planning#2668 ## References See: MetaMask/MetaMask-planning#2668 Unblocks: #4327 ## Changelog No user facing changes ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Jiexi Luan <jiexiluan@gmail.com> Co-authored-by: Derek Brans <dbrans@gmail.com>

legobeat · 2024-08-13T00:15:33Z

Superseded by #4591

legobeat added dependencies Pull requests that update a dependency file team-security labels May 28, 2024

legobeat force-pushed the deps-nonce-tracker-6 branch 5 times, most recently from 0d0f46c to 3d59210 Compare May 30, 2024 23:10

legobeat mentioned this pull request Jun 6, 2024

fix: force @metamask/nonce-tracker v6 through resolutions MetaMask/metamask-extension#25123

Closed

7 tasks

legobeat force-pushed the deps-nonce-tracker-6 branch 2 times, most recently from caa09ab to 2d19826 Compare June 6, 2024 22:32

legobeat force-pushed the deps-nonce-tracker-6 branch 2 times, most recently from 31bf8ca to 5a7b861 Compare June 8, 2024 00:50

legobeat mentioned this pull request Jun 8, 2024

chore(deps): bump @metamask/nonce-tracker from 5.0.0 to 6.0.0 #4329

Closed

legobeat marked this pull request as ready for review June 8, 2024 00:56

legobeat requested a review from a team June 8, 2024 00:56

legobeat force-pushed the deps-nonce-tracker-6 branch from 5a7b861 to 962fc13 Compare June 10, 2024 00:23

legobeat mentioned this pull request Jun 10, 2024

[Bug]: Unable to submit a transaction on BNB Chain (happens on any network, with BNB being more consistent to reproduce) MetaMask/metamask-extension#25134

Closed

legobeat force-pushed the deps-nonce-tracker-6 branch from 962fc13 to c807342 Compare June 10, 2024 09:27

mcmire previously approved these changes Jun 10, 2024

View reviewed changes

legobeat force-pushed the deps-nonce-tracker-6 branch from c807342 to d4c8478 Compare June 10, 2024 17:44

legobeat force-pushed the deps-nonce-tracker-6 branch from d4c8478 to 0f65e9e Compare June 10, 2024 18:06

This comment was marked as resolved.

Sign in to view

legobeat mentioned this pull request Jun 10, 2024

[publish-preview] #4327 #4398

Draft

kumavis previously approved these changes Jun 11, 2024

View reviewed changes

mikesposito previously approved these changes Jun 11, 2024

View reviewed changes

deps(transaction-controller): @metamask/nonce-tracker@^5.0.0->^6.0.0

32a2f8e

legobeat force-pushed the deps-nonce-tracker-6 branch from 0f65e9e to 32a2f8e Compare June 13, 2024 00:16

legobeat mentioned this pull request Jun 13, 2024

deps(network-controller): @metamask/eth-block-tracker@^9.0.3->^10.0.0 #4424

Merged

7 tasks

jiexi mentioned this pull request Jun 14, 2024

fix: disable some transaction controller integration tests #4429

Merged

3 tasks

Merge branch 'main' into deps-nonce-tracker-6

2682049

legobeat dismissed stale reviews from mikesposito, kumavis, and mcmire via 2682049 July 12, 2024 00:36

Merge branch 'main' into deps-nonce-tracker-6

7632c96

legobeat requested a review from a team as a code owner July 25, 2024 18:43

legobeat mentioned this pull request Jul 25, 2024

fix(deps): Bump @metamask/eth-json-rpc-middleware to ^14.0.0, @metamask/transaction-controller to ^35.1.1 MetaMask/metamask-extension#26143

Merged

7 tasks

Merge branch 'main' into deps-nonce-tracker-6

dee2f29

legobeat closed this Aug 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

deps(transaction-controller): @metamask/nonce-tracker@^5.0.0->^6.0.0 #4327

deps(transaction-controller): @metamask/nonce-tracker@^5.0.0->^6.0.0 #4327

Uh oh!

legobeat commented May 28, 2024 •

edited

Loading

Uh oh!

mcmire left a comment

Uh oh!

legobeat commented Jun 10, 2024

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

legobeat commented Jun 10, 2024

Uh oh!

legobeat commented Aug 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

deps(transaction-controller): @metamask/nonce-tracker@^5.0.0->^6.0.0 #4327

deps(transaction-controller): @metamask/nonce-tracker@^5.0.0->^6.0.0 #4327

Uh oh!

Conversation

legobeat commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

References

Changelog

@metamask/network-controller

@metamask/transaction-controller

Checklist

Uh oh!

mcmire left a comment

Choose a reason for hiding this comment

Uh oh!

legobeat commented Jun 10, 2024

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

legobeat commented Jun 10, 2024

Uh oh!

legobeat commented Aug 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

legobeat commented May 28, 2024 •

edited

Loading

`@metamask/network-controller`

`@metamask/transaction-controller`