Skip to content

deps(network-controller): eth-block-tracker@8 -> @metamask/eth-block-tracker@9 #4309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
legobeat merged 3 commits into from
May 28, 2024
Merged

deps(network-controller): eth-block-tracker@8 -> @metamask/eth-block-tracker@9 #4309

legobeat merged 3 commits into from
May 28, 2024

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented May 23, 2024 •
edited
Loading

Explanation

  • The package eth-block-tracker has been renamed to @metamask/eth-block-tracker.
    • This upgrades to the latest v9, which contains no breaking changes beyond the rename.
    • Also contains a bugfix for an issue with multiple redundant polling loops.
  • Associated upgrade of similarly renamed nonce-tracker to @metamask/nonce-tracker.

References

Blocked by

Changelog

@metamask/network-controller

  • FIXED: Update from eth-block-tracker@^8.0.0 to @metamask/eth-block-tracker@^9.0.1, mitigating issue with redundant polling loops

@metamask/transaction-controller

  • FIXED: BREAKING: Update from nonce-tracker@^3.0.0 to @metamask/nonce-tracker@^5.0.0 to mitigate issue with redundant polling loops in block tracker.
    • The constructor now expects the blockTracker option being an instance of @metamask/eth-block-tracker instead ofeth-block-tracker.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@socket-security
Copy link

socket-security bot commented May 23, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/eth-block-tracker@9.0.3 None 0 0 B
npm/@metamask/eth-json-rpc-middleware@12.1.1 None 0 0 B
npm/@metamask/nonce-tracker@5.0.0 None 0 0 B

🚮 Removed packages: npm/@metamask/eth-json-rpc-middleware@12.1.0

View full report↗︎

@legobeat legobeat force-pushed the deps-eth-block-tracker-9 branch 2 times, most recently from 0d2d8fc to 0694001 Compare May 24, 2024 00:47
@legobeat legobeat added bug Something isn't working dependencies Pull requests that update a dependency file labels May 24, 2024
@legobeat legobeat force-pushed the deps-eth-block-tracker-9 branch from c9ffc9d to 892c2e9 Compare May 27, 2024 21:37
@legobeat legobeat marked this pull request as ready for review May 27, 2024 21:38
@legobeat legobeat requested a review from a team May 27, 2024 21:38
@legobeat legobeat marked this pull request as draft May 27, 2024 22:05
@legobeat legobeat force-pushed the deps-eth-block-tracker-9 branch from 892c2e9 to 0197871 Compare May 28, 2024 06:39
@legobeat legobeat marked this pull request as ready for review May 28, 2024 06:40
@legobeat legobeat force-pushed the deps-eth-block-tracker-9 branch from 0197871 to deca5ec Compare May 28, 2024 06:50
@legobeat legobeat requested a review from Mrtenz May 28, 2024 08:13
@legobeat legobeat merged commit 89ea0d9 into MetaMask:main May 28, 2024
@legobeat legobeat mentioned this pull request May 28, 2024
Closed
6 tasks
@legobeat legobeat deleted the deps-eth-block-tracker-9 branch May 28, 2024 21:57
@legobeat legobeat restored the deps-eth-block-tracker-9 branch May 28, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

@kumavis kumavis Awaiting requested review from kumavis

@rekmarks rekmarks Awaiting requested review from rekmarks

@matthewwalsh0 matthewwalsh0 Awaiting requested review from matthewwalsh0

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

Assignees

No one assigned

Labels

bug Something isn't working dependencies Pull requests that update a dependency file

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@legobeat @Mrtenz