devDeps: eth-block-tracker@^8.1.0 -> @metamask/eth-block-tracker@^9.0.3; add as peerDep #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 27, 2024
Merged
Merged
rickycodes
previously approved these changes
May 28, 2024
legobeat
dismissed
rickycodes’s stale review
The merge-base changed after approval.
legobeat
force-pushed
the
deps-mm-eth-block-tracker
branch
from
14d1dfc to
9a2ab89
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/eth-json-rpc-provider@2.3.2, npm/@metamask/json-rpc-engine@7.3.3, npm/eth-block-tracker@8.1.0 |
legobeat
commented
May 28, 2024
| "xtend": "^4.0.1" | ||
| }, | ||
| "peerDependencies": { | ||
| "@metamask/eth-block-tracker": ">=9" |
Contributor
Author
There was a problem hiding this comment.
Defaulting to a more liberal range here so by default new major releases of @metamask/eth-block-tracker won't require entire upgrade cycle of @metamask/nonce-tracker.
legobeat
force-pushed
the
deps-mm-eth-block-tracker
branch
from
9a2ab89 to
34ac0fc
Compare
kumavis
approved these changes
May 28, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eth-block-trackerto latest@metamask/eth-block-tracker@metamask/eth-block-trackertopeerDependencieseth-block-trackeras already implicit peeerDep by being mandatory constructor option. This makes that explicit.Related