Skip to content

chore: update accounts deps #5366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ccharly merged 4 commits into from
Feb 20, 2025
Merged

chore: update accounts deps #5366

ccharly merged 4 commits into from
Feb 20, 2025

Conversation

@ccharly
Copy link
Contributor

@ccharly ccharly commented Feb 20, 2025 •
edited
Loading

Explanation

Aligning accounts-related dependencies.

References

N/A

Changelog

CHANGELOG.mds have been updated accordingly.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@socket-security
Copy link

socket-security bot commented Feb 20, 2025 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/eth-snap-keyring@11.1.0 Transitive: environment, filesystem +47 8.57 MB metamaskbot

View full report↗︎

@ccharly ccharly marked this pull request as ready for review February 20, 2025 17:02
@ccharly ccharly requested review from a team as code owners February 20, 2025 17:02
gantunesr

This comment was marked as outdated.

Sign in to view

gantunesr
gantunesr reviewed Feb 20, 2025
View reviewed changes
gantunesr
gantunesr reviewed Feb 20, 2025
View reviewed changes
@gantunesr gantunesr dismissed their stale review February 20, 2025 17:21

minor change requested

@ccharly ccharly enabled auto-merge (squash) February 20, 2025 17:29
@ccharly ccharly merged commit 2999181 into main Feb 20, 2025
136 checks passed
@ccharly ccharly deleted the chore/update-accounts-deps branch February 20, 2025 18:14
github-merge-queue bot pushed a commit to MetaMask/metamask-mobile that referenced this pull request Mar 25, 2025
@mikesposito
fix: bump @metamask/keyring-controller to ^19.2.2 (#14229)
99faccf 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
`@metamask/keyring-controller` is being updated to 19.2.2 including the
following changes:

```markdown
## [19.2.2]

### Fixed

- Fixed duplication of unsupported keyrings ([#5535](MetaMask/core#5535))
- Enforce keyrings metadata alignment when unlocking existing vault ([#5535](MetaMask/core#5535))
- Fixed frozen object mutation attempt when updating metadata ([#5535](MetaMask/core#5535))

## [19.2.1]

### Changed

- Bump `@metamask/keyring-api"` from `^17.0.0` to `^17.2.0` ([#5366](MetaMask/core#5366))
- Bump `@metamask/keyring-internal-api` from `^4.0.1` to `^4.0.3` ([#5356](MetaMask/core#5356)), ([#5366](MetaMask/core#5366))

### Fixed

- Ensure authorization contract address is provided ([#5353](MetaMask/core#5353))
```

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
mikesposito added a commit to MetaMask/metamask-extension that referenced this pull request Mar 25, 2025
@mikesposito @metamaskbot
fix: bump @metamask/keyring-controller to ^19.2.2 (#31293)
d0e903d 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
Bumping `@metamask/keyring-controller` to 19.2.2

```markdown
## [19.2.2]

### Fixed

- Fixed duplication of unsupported keyrings ([#5535](MetaMask/core#5535))
- Enforce keyrings metadata alignment when unlocking existing vault ([#5535](MetaMask/core#5535))
- Fixed frozen object mutation attempt when updating metadata ([#5535](MetaMask/core#5535))

## [19.2.1]

### Changed

- Bump `@metamask/keyring-api"` from `^17.0.0` to `^17.2.0` ([#5366](MetaMask/core#5366))
- Bump `@metamask/keyring-internal-api` from `^4.0.1` to `^4.0.3` ([#5356](MetaMask/core#5356)), ([#5366](MetaMask/core#5366))

### Fixed

- Ensure authorization contract address is provided ([#5353](MetaMask/core#5353))
```

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/31293?quickstart=1)

## **Related issues**

Related: #31200

## **Manual testing steps**

1. Start with an installation from before we introduced
keyringsMetadata, proceed past onboarding so that you have a vault setup
(e.g. v12.12.0)
2. Upgrade to this branch
3. Start the extension (without logging in)
4. Leave the window open a while to give it time to initialize all
controllers
5. Reload the extension before unlocking
6. Try to unlock the wallet

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
runway-github bot added a commit to MetaMask/metamask-mobile that referenced this pull request Mar 25, 2025
@runway-github
temp+fix: bump @metamask/keyring-controller to ^19.2.2 (#14229)
db54839 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
`@metamask/keyring-controller` is being updated to 19.2.2 including the
following changes:

```markdown
## [19.2.2]

### Fixed

- Fixed duplication of unsupported keyrings ([#5535](MetaMask/core#5535))
- Enforce keyrings metadata alignment when unlocking existing vault ([#5535](MetaMask/core#5535))
- Fixed frozen object mutation attempt when updating metadata ([#5535](MetaMask/core#5535))

## [19.2.1]

### Changed

- Bump `@metamask/keyring-api"` from `^17.0.0` to `^17.2.0` ([#5366](MetaMask/core#5366))
- Bump `@metamask/keyring-internal-api` from `^4.0.1` to `^4.0.3` ([#5356](MetaMask/core#5356)), ([#5366](MetaMask/core#5366))

### Fixed

- Ensure authorization contract address is provided ([#5353](MetaMask/core#5353))
```

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
runway-github bot added a commit to MetaMask/metamask-mobile that referenced this pull request Mar 25, 2025
@runway-github
temp+fix: bump @metamask/keyring-controller to ^19.2.2 (#14229)
3fbda68 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
`@metamask/keyring-controller` is being updated to 19.2.2 including the
following changes:

```markdown
## [19.2.2]

### Fixed

- Fixed duplication of unsupported keyrings ([#5535](MetaMask/core#5535))
- Enforce keyrings metadata alignment when unlocking existing vault ([#5535](MetaMask/core#5535))
- Fixed frozen object mutation attempt when updating metadata ([#5535](MetaMask/core#5535))

## [19.2.1]

### Changed

- Bump `@metamask/keyring-api"` from `^17.0.0` to `^17.2.0` ([#5366](MetaMask/core#5366))
- Bump `@metamask/keyring-internal-api` from `^4.0.1` to `^4.0.3` ([#5356](MetaMask/core#5356)), ([#5366](MetaMask/core#5366))

### Fixed

- Ensure authorization contract address is provided ([#5353](MetaMask/core#5353))
```

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
runway-github bot pushed a commit to MetaMask/metamask-mobile that referenced this pull request Mar 25, 2025
@mikesposito
chore(runway): cherry-pick fix: bump @metamask/keyring-controller t…
a49ddec 
…o `^19.2.2` (#14229)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
`@metamask/keyring-controller` is being updated to 19.2.2 including the
following changes:

```markdown
## [19.2.2]

### Fixed

- Fixed duplication of unsupported keyrings ([#5535](MetaMask/core#5535))
- Enforce keyrings metadata alignment when unlocking existing vault ([#5535](MetaMask/core#5535))
- Fixed frozen object mutation attempt when updating metadata ([#5535](MetaMask/core#5535))

## [19.2.1]

### Changed

- Bump `@metamask/keyring-api"` from `^17.0.0` to `^17.2.0` ([#5366](MetaMask/core#5366))
- Bump `@metamask/keyring-internal-api` from `^4.0.1` to `^4.0.3` ([#5356](MetaMask/core#5356)), ([#5366](MetaMask/core#5366))

### Fixed

- Ensure authorization contract address is provided ([#5353](MetaMask/core#5353))
```

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
MarioAslau pushed a commit to MetaMask/metamask-mobile that referenced this pull request Mar 25, 2025
@runway-github @mikesposito
chore(runway): cherry-pick fix: bump @metamask/keyring-controller t…
01e3767 
…o `^19.2.2` (#14236)

- fix: bump `@metamask/keyring-controller` to `^19.2.2` (#14229)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
`@metamask/keyring-controller` is being updated to 19.2.2 including the
following changes:

```markdown
## [19.2.2]

### Fixed

- Fixed duplication of unsupported keyrings ([#5535](MetaMask/core#5535))
- Enforce keyrings metadata alignment when unlocking existing vault ([#5535](MetaMask/core#5535))
- Fixed frozen object mutation attempt when updating metadata ([#5535](MetaMask/core#5535))

## [19.2.1]

### Changed

- Bump `@metamask/keyring-api"` from `^17.0.0` to `^17.2.0` ([#5366](MetaMask/core#5366))
- Bump `@metamask/keyring-internal-api` from `^4.0.1` to `^4.0.3` ([#5356](MetaMask/core#5356)), ([#5366](MetaMask/core#5366))

### Fixed

- Ensure authorization contract address is provided ([#5353](MetaMask/core#5353))
```

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding

Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
[99faccf](99faccf)

Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com>
sethkfman pushed a commit to MetaMask/metamask-mobile that referenced this pull request Apr 9, 2025
@mikesposito @metamaskbot
fix: bump @metamask/keyring-controller to ^19.2.2 (#14229)
d416c5b 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
`@metamask/keyring-controller` is being updated to 19.2.2 including the
following changes:

```markdown
## [19.2.2]

### Fixed

- Fixed duplication of unsupported keyrings ([#5535](MetaMask/core#5535))
- Enforce keyrings metadata alignment when unlocking existing vault ([#5535](MetaMask/core#5535))
- Fixed frozen object mutation attempt when updating metadata ([#5535](MetaMask/core#5535))

## [19.2.1]

### Changed

- Bump `@metamask/keyring-api"` from `^17.0.0` to `^17.2.0` ([#5366](MetaMask/core#5366))
- Bump `@metamask/keyring-internal-api` from `^4.0.1` to `^4.0.3` ([#5356](MetaMask/core#5356)), ([#5366](MetaMask/core#5366))

### Fixed

- Ensure authorization contract address is provided ([#5353](MetaMask/core#5353))
```

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mathieuartu mathieuartu mathieuartu approved these changes

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@gantunesr gantunesr gantunesr approved these changes

@gambinish gambinish gambinish approved these changes

Assignees

No one assigned

Labels

None yet

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ccharly @mathieuartu @Prithpal-Sooriya @gantunesr @gambinish