Seedless controller: Add "@noble" dependencies as main dependencies #6101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasgeihs
force-pushed
the
mg/fix-seedless-dependencies
branch
from
c8788f9 to
d2fe10f
Compare
matthiasgeihs
force-pushed
the
mg/fix-seedless-dependencies
branch
from
d2fe10f to
74026d4
Compare
matthiasgeihs
changed the title
| "@metamask/base-controller": "^8.0.1", | ||
| "@metamask/controller-utils": "^11.11.0", | ||
| "@noble/hashes": "^1.4.0", | ||
| "@noble/hashes": "^1.8.0", |
Contributor
There was a problem hiding this comment.
Nit: instead of using no-changelog could we add a changelog entry for this bump
Comment on lines
+106
to
+107
| "@noble/ciphers": "^1.3.0", | ||
| "@noble/hashes": "^1.8.0", |
Contributor
There was a problem hiding this comment.
Nit: instead of using no-changelog could we add a changelog entries for these bumps
Comment on lines
+54
to
+56
| "@noble/ciphers": "^1.3.0", | ||
| "@noble/curves": "^1.9.2", | ||
| "@noble/hashes": "^1.8.0", |
Contributor
There was a problem hiding this comment.
Nit: instead of using no-changelog could we add a changelog entries for these bumps and that they are being now used as dependencies
matthiasgeihs
force-pushed
the
mg/fix-seedless-dependencies
branch
from
2983e5c to
c0e611a
Compare
Contributor
Author
|
rebased |
matthiasgeihs
force-pushed
the
mg/fix-seedless-dependencies
branch
from
c0e611a to
29a2046
Compare
matthiasgeihs
force-pushed
the
mg/fix-seedless-dependencies
branch
from
29a2046 to
79b0b08
Compare
cryptotavares
approved these changes
Aug 4, 2025
Contributor
|
Thanks for doing this. LGTM! I know this could be a hassle, but considering how critical backup & sync features are, could we please make sure to include client test-drive PRs to make sure:
|
Contributor
This can be done following those steps:
|
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Contributor
Author
|
@mathieuartu have created PRs in mobile and extension, please have a look. |
mathieuartu
approved these changes
Aug 4, 2025
Contributor
mathieuartu
left a comment
mathieuartu
left a comment
There was a problem hiding this comment.
Thanks a ton! Verified E2Es and did manual test runs, all seems to be working fine :)
matthiasgeihs
force-pushed
the
mg/fix-seedless-dependencies
branch
from
79b0b08 to
b69aa52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The dependencies
@noble/hashes,@noble/ciphers,@noble/curveswere mistakenly listed as dev-dependencies inseedless-controller. Moving them to main dependencies here.Also upgrading all
@nobledependencies to most recent version. In particular,@noble/ciphershas now a v1 which is audited.References
Changelog
Checklist