chore: update @noble dependencies in core #34833
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
matthiasgeihs
force-pushed
the
mg/update-noble-dependencies
branch
from
a24e8ea to
5e7430e
Compare
Collaborator
✨ Files requiring CODEOWNER review ✨🧩 @MetaMask/extension-devs (5 files, +12 -32)
📜 @MetaMask/policy-reviewers (5 files, +12 -32)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔗 @MetaMask/supply-chain (5 files, +12 -32)
|
4 tasks
Collaborator
Builds ready [5e7483c]
UI Startup Metrics (1198 ± 65 ms)
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 239 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2260 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2624 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 385 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 270 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 8 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 225 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 27 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 31 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 49 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 263 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 62 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 58 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 32 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 313ms | Sum of p95 exceeds: 690.8ms Sum of all benchmark exceeds: 1003.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
Contributor
Author
|
testing successful |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test integration for updating
@nobledependencies in core.Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist