Skip to content

Revert "Remove dependency on color lib and upgrade version to 2.1.0"#24

Merged
georgewrmarshall merged 2 commits intomasterfrom
revert-d923914
Mar 19, 2025
Merged

Revert "Remove dependency on color lib and upgrade version to 2.1.0"#24
georgewrmarshall merged 2 commits intomasterfrom
revert-d923914

Conversation

@mcmire
Copy link

@mcmire mcmire commented Jul 18, 2024

This reverts commit d923914.

It seems that the implementation of hueShift is slightly different in this commit than before and therefore produces slightly different colors as before. Reverting so that we can fix this bug.

@socket-security
Copy link

socket-security bot commented Jul 19, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/color@0.11.4 None +4 78.2 kB qix

View full report↗︎

@socket-security
Copy link

socket-security bot commented Jul 19, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/color-string@0.3.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

…)"

This reverts commit d923914.

It seems that the implementation of `hueShift` is slightly different in
this commit than before and therefore produces slightly different colors
as before. Reverting so that we can fix this bug.
@mcmire
Copy link
Author

mcmire commented Jul 19, 2024

@SocketSecurity ignore npm/color-string@0.3.0

New author is okay, I reviewed his profile and latest contributions on GitHub and he seems trustworthy.

@mcmire mcmire requested a review from a team July 19, 2024 17:36
@georgewrmarshall georgewrmarshall merged commit cb7e718 into master Mar 19, 2025
12 checks passed
@georgewrmarshall georgewrmarshall deleted the revert-d923914 branch March 19, 2025 20:13
@mcmire
Copy link
Author

mcmire commented Mar 19, 2025

For posterity, I ran npm run build-demo and compared this commit with the one that I reverted. There is in fact a very minute difference. It's really hard to capture in a screenshot, but it is there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants