Remove dependency on color lib and upgrade version to 2.1.0#6
Merged
rekmarks merged 2 commits intoMetaMask:masterfrom May 7, 2021
Merged
Remove dependency on color lib and upgrade version to 2.1.0#6rekmarks merged 2 commits intoMetaMask:masterfrom
rekmarks merged 2 commits intoMetaMask:masterfrom
Conversation
danfinlay
approved these changes
May 7, 2021
danfinlay
left a comment
danfinlay
left a comment
There was a problem hiding this comment.
Looks good to me, happy to remove a dep and reduce bundle size! Will want to do a quick visual verification before pushing to npm, but otherwise looks safe.
Author
Agreed, visual confirmation from another consumer of the lib would be good! FWIW here's a quick confirmation from my own app: |
rekmarks
approved these changes
May 7, 2021
mcmire
added a commit
that referenced
this pull request
Jul 18, 2024
…)" This reverts commit d923914. It seems that the implementation of `hueShift` is slightly different in this commit than before and therefore produces slightly different colors as before. Reverting so that we can fix this bug.
mcmire
added a commit
that referenced
this pull request
Jul 19, 2024
…)" This reverts commit d923914. It seems that the implementation of `hueShift` is slightly different in this commit than before and therefore produces slightly different colors as before. Reverting so that we can fix this bug.
mcmire
added a commit
that referenced
this pull request
Jul 19, 2024
…)" This reverts commit d923914. It seems that the implementation of `hueShift` is slightly different in this commit than before and therefore produces slightly different colors as before. Reverting so that we can fix this bug.
georgewrmarshall
pushed a commit
that referenced
this pull request
Mar 19, 2025
…24) Revert "Remove dependency on color lib and upgrade version to 2.1.0 (#6)" This reverts commit d923914. It seems that the implementation of `hueShift` is slightly different in this commit than before and therefore produces slightly different colors as before. Reverting so that we can fix this bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This hoists up the little bit of color manipulation logic needed from the color library in order to remove that dependency. The bulk of jazzicon's bundle size came from color so this significantly reduced it (~20Kb reduction).
It also increases the major version number to mark the change.
Testing
Tested in Safari, Firefox, and Chrome (via https://celowallet.app) on known addresses and can confirm they render correctly.