Skip to content

Conversation

@DDDDDanica
Copy link
Contributor

@DDDDDanica DDDDDanica commented Apr 30, 2025

Previously the Multichain API was only available on Flask and Beta builds. Starting in 12.18.0 we are releasing the Multichain API to all build types including stable

Open in GitHub Codespaces
Cherry-pick: https://github.com/MetaMask/metamask-extension/pull/32351/files
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4779

  1. Build this branch in a normal stable build (yarn start)
  2. Go to https://metamask.github.io/test-dapp-multichain/latest/
  3. Enter your extensionId (watch video below to see where) -> Detection on stable blocked by 22.1.0 providers#420
  4. See that you're able to connect and interact with the multichain api
Screen.Recording.2025-04-28.at.2.44.45.PM.mov
Screen.Recording.2025-04-28.at.3.50.31.PM.mov
  • I've followed MetaMask Contributor Docs and MetaMask Extension Coding
    Standards
    .

  • I've completed the PR template to the best of my ability

  • I’ve included tests if applicable

  • I’ve documented my code using JSDoc format if applicable

  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).

  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.


Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…ultichain API on all build types (#32351)

Previously the Multichain API was only available on Flask and Beta
builds. Starting in 12.18.0 we are releasing the Multichain API to all
build types including `stable`

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32351?quickstart=1)

Fixes: MetaMask/MetaMask-planning#4779

1. Build this branch in a normal stable build (`yarn start`)
2. Go to https://metamask.github.io/test-dapp-multichain/latest/
3. Enter your extensionId (watch video below to see where) -> Detection
on `stable` blocked by MetaMask/providers#420
4. See that you're able to connect and interact with the multichain api

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

https://github.com/user-attachments/assets/282cfd24-428f-4eff-ab27-1a9424c27ad0

https://github.com/user-attachments/assets/7af12e3c-05a8-4277-a439-5c54fefdd13d

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: jiexi <jiexiluan@gmail.com>
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Apr 30, 2025
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​providers@​22.0.1 ⏵ 22.1.0991009298 +1100

View full report

@DDDDDanica DDDDDanica merged commit 1b6b072 into Version-v12.18.0 Apr 30, 2025
158 of 162 checks passed
@DDDDDanica DDDDDanica deleted the cherry-pick-1e7abc4a6bdf56bbdc69a88dcc412b79b752165e branch April 30, 2025 11:45
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [dffde0b]
UI Startup Metrics (1193 ± 55 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1193108013345512341286
load104093911755410891133
domContentLoaded103593111705410811127
domInteractive16134351627
firstPaint712135117641110531114
backgroundConnect6311179
firstReactRender20154652134
getState1253571630
initialActions001001
loadScripts79867593752838876
setupStore74192713
WebpackHomeuiStartup21391750246817222622406
load16781352200313717661889
domContentLoaded16721349199813717601886
domInteractive161157101445
firstPaint1896639175247331
backgroundConnect26989143053
firstReactRender19253384118307355
getState123172171227
initialActions318136
loadScripts16671344197413717571876
setupStore207199262141
FirefoxBrowserifyHomeuiStartup13681198177110714111601
load12191038164210812761428
domContentLoaded12191038164210812761428
domInteractive1053924331116162
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2113107112137
firstReactRender22203432329
getState9418318818
initialActions005101
loadScripts12001024162810712621409
setupStore6424368
WebpackHomeuiStartup14841332188010815501707
load1273115615799113181456
domContentLoaded1273115515799113171455
domInteractive82572272390126
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21146062328
firstReactRender34285553646
getState12430330929
initialActions102111
loadScripts1254114015589012961434
setupStore85454811

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants